New issue
Advanced search Search tips

Issue 593678 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

SetupTraceRerunOptions is not called for mem-infra benchmarks.

Project Member Reported by u...@chromium.org, Mar 10 2016

Issue description

perezju@ from https://codereview.chromium.org/1773103002:

SetupTraceRerunOptions is only called for old style
PageTest benchmarks, and not for new TBM ones (c.f. [1]). Please leave a
TODO here and file a bug on me to get this fixed, as this is also broken
for other benchmarks above.

[1]:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapult/telemetry/telemetry/benchmark.py&l=191
 
For reference, issue filed to fix this on the catapult side: https://github.com/catapult-project/catapult/issues/2126

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcb9574723963b3e2b9eec46baa8b0d1d230bf6c

commit bcb9574723963b3e2b9eec46baa8b0d1d230bf6c
Author: perezju <perezju@chromium.org>
Date: Wed Mar 16 11:26:49 2016

[memory_infra] Fix trace rerun options in memory benchmarks

BUG= 593678 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1785683002

Cr-Commit-Position: refs/heads/master@{#381434}

[modify] https://crrev.com/bcb9574723963b3e2b9eec46baa8b0d1d230bf6c/tools/perf/benchmarks/memory_infra.py

Status: Fixed (was: Assigned)

Sign in to add a comment