NULL pointers used in gl bindings without any checks |
||
Issue descriptionThe GL functions in gl_binding [1] and similar files can be set to a NULL pointer if the function is not defined on the given GL version, but there is no check for this case. Adding some DCHECKs for at least the debug version of the calls could make debugging of segfaults of this kind much easier. It personally happened to me that the program was behaving rather oddly under gdb when a segfault was occurring because of a NULL pointer and a DCHECK would have saved me a lot of time. [1] https://code.google.com/p/chromium/codesearch#chromium/src/ui/gl/gl_bindings_autogen_gl.cc&l=2038
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51f03fb7c106cdbadb014dcba1bf6b570da928b7 commit 51f03fb7c106cdbadb014dcba1bf6b570da928b7 Author: martina.kollarova <martina.kollarova@intel.com> Date: Fri Mar 11 16:46:34 2016 Add DCHECK for nullptr in gl bindings BUG= 593666 Review URL: https://codereview.chromium.org/1775353002 Cr-Commit-Position: refs/heads/master@{#380651} [modify] https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7/ui/gl/generate_bindings.py [modify] https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7/ui/gl/gl_bindings_autogen_egl.cc [modify] https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7/ui/gl/gl_bindings_autogen_gl.cc [modify] https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7/ui/gl/gl_bindings_autogen_glx.cc [modify] https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7/ui/gl/gl_bindings_autogen_osmesa.cc [modify] https://crrev.com/51f03fb7c106cdbadb014dcba1bf6b570da928b7/ui/gl/gl_bindings_autogen_wgl.cc
,
Mar 14 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by martina....@intel.com
, Mar 10 2016Status: Started (was: Untriaged)