Regression: [md] Misalignment of infobar is observed under location bar
Reported by
dmascare...@etouch.net,
Mar 10 2016
|
||||||||||||||||||
Issue descriptionChrome Version:51.0.2673.0 (Official Build)764e6bb1b05458cde3ca0702ceb801d25c3dcc3b-refs/heads/master@{#380313} 64 bit OS:Mac Pre-condition: Select 'Material' option for 'Material design in the browser's top chrome'. What steps will reproduce the problem? 1. Launch chrome and Enter 'about:inducebrowsercrashforrealz' in omnibox such that chrome browser crashes. 2. Now reopen the browser and observe. Actual: Misalignment of the infobar is observed. Expected: Infobar should be proper. This is regression issue, broken in ‘M 51’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/a6c42bddb0ce6253b7da6f3b66460a243071d04f..dd5ed50fcfaba45855d3a3c63084e74011dd6166?pretty=fuller&n=100 Suspecting: r378233 ? Good build:51.0.2663.0 Bad build:51.0.2664.0 Note: 1. Issue is not seen on Windows and Linux OS. 2. Above issue is seen on all type of infobar such as 'Default browser' infobar
,
Mar 10 2016
Can you find someone who has worked on bubbles/infobar to check this? This should not be a result of any changes I made in the code. There is code in various places in the code base looking for the Material Design flag. It could be that this is the correct position for bubbles in Material Design.
,
Mar 11 2016
CC'ing @dbeam, request you to please take a look into it and please help us to find an owner to triage the issue. Thanks.!a
,
Mar 11 2016
i think crashing your browser started a newer version of Chrome with a different UI (i.e. field trial)
,
Mar 13 2016
I can reproduce this issue e.g. with the Translation Infobar when Material Design is enabled. Please see enclosed the screenshots. estade@: Could you please take a look at this issue. I see that you are working on MD Infobar changes ( issue 520266 ). Or may be you can assign it to the right person who is working for Mac Infobars? Many thanks.
,
Mar 14 2016
I believe your work on the toolbar means you need to change kPageInfoBubblePointYOffset which is used to position the infobar on cocoa.
,
Mar 15 2016
Thank you for the pointer estade@ - I will take a look.
,
Mar 22 2016
Removing release block - this is only for users with Material Design switched on.
,
Apr 13 2016
,
Apr 13 2016
,
Apr 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fada7682f1b88e2615ef3261ed86e0b0a5f2765 commit 7fada7682f1b88e2615ef3261ed86e0b0a5f2765 Author: shrike <shrike@chromium.org> Date: Wed Apr 13 23:34:57 2016 [Mac] Increase infobar height under Material Design. Under Material Design the infobar height has increased slightly. R=avi@chromium.org BUG= 593664 Review URL: https://codereview.chromium.org/1885903003 Cr-Commit-Position: refs/heads/master@{#387146} [modify] https://crrev.com/7fada7682f1b88e2615ef3261ed86e0b0a5f2765/chrome/browser/ui/cocoa/infobars/infobar_controller.mm [modify] https://crrev.com/7fada7682f1b88e2615ef3261ed86e0b0a5f2765/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
,
Apr 13 2016
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 10 2016