'Undo' and 'Restore all' options are not visible on NTP for 'Like' theme.
Reported by
dchau...@etouch.net,
Mar 10 2016
|
||||||
Issue descriptionChrome Version: 50.0.2661.26 (Official Build) 0abdf9cbb43ea5639687aa21a2bcb206b1dc6d7b-refs/branch-heads/2661@{#169} 32/64-bit. OS: All(Win 7-Aero enabled) URL: https://chrome.google.com/webstore/detail/like/fmmdfldoaocolmibeehmndgcmlbidppj?hl=en What steps will reproduce the problem? 1. Launch chrome, go to above URL and click on 'ADD TO CHROME' button. 2. Now, go to NTP, delete any thumbnail by clicking on cross (X) button and observe. 'Undo' and 'Restore all' options are not visible on NTP. 'Undo' and 'Restore all' options should be visible on NTP. This is a non regression issue, seen from M-31 series. Kindly review the attached screencast for reference.
,
Mar 10 2016
Untriaging it so that it gets addressed.
,
Mar 10 2016
Themes team, is the color of this link text under the control of the theme creator? Otherwise, we need to be more careful in color selection for some themes.
,
Mar 31 2016
themes team - gentle ping
,
Mar 31 2016
Adding a couple of themes owners.
,
Mar 31 2016
I would say the bigger problem is that the google logo is almost completely invisible. NTP team should address both issues.
,
Apr 13 2016
wrt the Google logo: We have some simple logic in place which tries to determine the right logo (regular or light): https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/themes/theme_service.cc&l=716 If the logic fails, the theme creator has to overwrite that decision with ntp_logo_alternate=0|1. However, I just wanted to try that. And to my surprise the value of ntp_logo_alternate doesn't have any effect on the logo. Issue 39668 is exactly about that. But it seems to be abandoned. wrt 'Undo' and 'Restore all': The text color is determined by the setting "ntp_text". But the theme creator set that to [ 245, 244, 30 ], which is just very close to the background color.
,
Apr 14 2016
hmm ... now it's working. No idea why. Probably I made some mistake yesterday. So with ntp_logo_alternate = 0 and "ntp_text": [ 0, 0, 0 ], it looks good (see screenshot). Closing this as WAI. The theme creator has to fix it. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zdenek.s...@seznam.cz
, Mar 10 201614.2 KB
14.2 KB View Download