New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593640 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Apps' icon and 'Import bookmarks now...' under the theme permission bar is not clickable.

Reported by lpa...@etouch.net, Mar 10 2016

Issue description

Chrome Version: 50.0.2661.26 0abdf9cbb43ea5639687aa21a2bcb206b1dc6d7b-refs/branch-heads/2661@{#169} (32/64 bit)
OS: Windows (Win-7 Aero-Enabled)
URL: https://chrome.google.com/webstore/detail/superman-theme-red-on-blu/dmodppofjbaoggbchnngcaljngfffloj?hl=en
Steps:
1. Launch chrome and install any theme (for eg. navigate to above url and install the theme)
2. Open a new tab page while installing the theme
3. Try clicking the 'Apps' icon or 'Import bookmarks now...' under the theme permission bar and observe.

Actual: 'Apps' icon or 'Import bookmarks now...' under the theme permission bar is not clickable.

Expected: 'Apps' icon or 'Import bookmarks now...' under the theme permission bar should be clickable.

This is a regression issue broken in M-50, will soon update the other info.
 

Comment 1 Deleted

Comment 2 by lpa...@etouch.net, Mar 10 2016

Manual Regression Range:
Good Build: 50.0.2660.0
Bad Build: 50.0.2661.11

Narrow Bisect: 
https://chromium.googlesource.com/chromium/src/+log/3fa2f06f7b1026322b9ed225002833d217acc5fc..03f21833a4b295548f64c07458ceb6f2409710a7?pretty=fuller&n=100

Suspecting: r377905

Note: Issue is not seen in Mac OS.
theme_actual.mp4
2.2 MB Download
theme_expected.mp4
1.3 MB Download
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Able to reproduce the issue on windows 7 using chrome latest canary version 51.0.2677.0.

estade@ could you please look into this issue if it is related to your change,else please route this to an appropriate owner for this issue.

Thanks, 
Able to reproduce the issue on windows 7 using chrome latest canary version 51.0.2677.0.

catapult-deps-roller@ could anyone please look into this issue if it is related to your change,else please help us in assigning it to the right owner

Thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/966e15221d7c60c7922d94af047a6663cb175c1e

commit 966e15221d7c60c7922d94af047a6663cb175c1e
Author: estade <estade@chromium.org>
Date: Tue Mar 15 18:48:11 2016

[md] Give each infobar its own layer.

This is necessary so latter bars can draw their arrow above the previous bar.
This is similar to  crbug.com/589771  , the fix for which only worked for the first infobar.

This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar.

BUG= 592727 ,  593640 

Review URL: https://codereview.chromium.org/1767363002

Cr-Commit-Position: refs/heads/master@{#381267}

[modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.h

Comment 7 by est...@chromium.org, Mar 15 2016

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 18 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603

commit f4ee21f5b2c49c57ca897b85c1ed67b375ad2603
Author: Evan Stade <estade@chromium.org>
Date: Fri Mar 18 18:35:57 2016

[md] Give each infobar its own layer.

This is necessary so latter bars can draw their arrow above the previous bar.
This is similar to  crbug.com/589771  , the fix for which only worked for the first infobar.

This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar.

BUG= 592727 ,  593640 

Review URL: https://codereview.chromium.org/1767363002

Cr-Commit-Position: refs/heads/master@{#381267}
(cherry picked from commit 966e15221d7c60c7922d94af047a6663cb175c1e)

Review URL: https://codereview.chromium.org/1817573002 .

Cr-Commit-Position: refs/branch-heads/2661@{#283}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.h

Labels: TE-Verified-50.0.2661.48 TE-Verified-M50
Tested the issue on windows 7, Linux Ubuntu 14.04 using chrome version 50.0.2661.48.Able to click on Apps and bookmarks while installing the theme.
Please find the attached screen cast for the same.

Adding TE-Verified label.
593640.mp4
943 KB Download

Sign in to add a comment