Issue metadata
Sign in to add a comment
|
Regression: 'Apps' icon and 'Import bookmarks now...' under the theme permission bar is not clickable.
Reported by
lpa...@etouch.net,
Mar 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 50.0.2661.26 0abdf9cbb43ea5639687aa21a2bcb206b1dc6d7b-refs/branch-heads/2661@{#169} (32/64 bit) OS: Windows (Win-7 Aero-Enabled) URL: https://chrome.google.com/webstore/detail/superman-theme-red-on-blu/dmodppofjbaoggbchnngcaljngfffloj?hl=en Steps: 1. Launch chrome and install any theme (for eg. navigate to above url and install the theme) 2. Open a new tab page while installing the theme 3. Try clicking the 'Apps' icon or 'Import bookmarks now...' under the theme permission bar and observe. Actual: 'Apps' icon or 'Import bookmarks now...' under the theme permission bar is not clickable. Expected: 'Apps' icon or 'Import bookmarks now...' under the theme permission bar should be clickable. This is a regression issue broken in M-50, will soon update the other info.
,
Mar 10 2016
Manual Regression Range: Good Build: 50.0.2660.0 Bad Build: 50.0.2661.11 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/3fa2f06f7b1026322b9ed225002833d217acc5fc..03f21833a4b295548f64c07458ceb6f2409710a7?pretty=fuller&n=100 Suspecting: r377905 Note: Issue is not seen in Mac OS.
,
Mar 10 2016
Adding release block label, please undo if not the case.
,
Mar 14 2016
Able to reproduce the issue on windows 7 using chrome latest canary version 51.0.2677.0. estade@ could you please look into this issue if it is related to your change,else please route this to an appropriate owner for this issue. Thanks,
,
Mar 14 2016
Able to reproduce the issue on windows 7 using chrome latest canary version 51.0.2677.0. catapult-deps-roller@ could anyone please look into this issue if it is related to your change,else please help us in assigning it to the right owner Thanks!
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/966e15221d7c60c7922d94af047a6663cb175c1e commit 966e15221d7c60c7922d94af047a6663cb175c1e Author: estade <estade@chromium.org> Date: Tue Mar 15 18:48:11 2016 [md] Give each infobar its own layer. This is necessary so latter bars can draw their arrow above the previous bar. This is similar to crbug.com/589771 , the fix for which only worked for the first infobar. This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar. BUG= 592727 , 593640 Review URL: https://codereview.chromium.org/1767363002 Cr-Commit-Position: refs/heads/master@{#381267} [modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_container_view.cc [modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.cc [modify] https://crrev.com/966e15221d7c60c7922d94af047a6663cb175c1e/chrome/browser/ui/views/infobars/infobar_view.h
,
Mar 15 2016
,
Mar 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603 commit f4ee21f5b2c49c57ca897b85c1ed67b375ad2603 Author: Evan Stade <estade@chromium.org> Date: Fri Mar 18 18:35:57 2016 [md] Give each infobar its own layer. This is necessary so latter bars can draw their arrow above the previous bar. This is similar to crbug.com/589771 , the fix for which only worked for the first infobar. This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar. BUG= 592727 , 593640 Review URL: https://codereview.chromium.org/1767363002 Cr-Commit-Position: refs/heads/master@{#381267} (cherry picked from commit 966e15221d7c60c7922d94af047a6663cb175c1e) Review URL: https://codereview.chromium.org/1817573002 . Cr-Commit-Position: refs/branch-heads/2661@{#283} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_container_view.cc [modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.cc [modify] https://crrev.com/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603/chrome/browser/ui/views/infobars/infobar_view.h
,
Mar 22 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 using chrome version 50.0.2661.48.Able to click on Apps and bookmarks while installing the theme. Please find the attached screen cast for the same. Adding TE-Verified label. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 Deleted