New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593624 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Mar 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:[Devtools] Focus issue is seen in Resources tab of devtools on changing the docking.

Project Member Reported by radhakri...@techmahindra.com, Mar 10 2016 
Chrome Version       : 50.0.2661.26 (Official Build)
OS Version : Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome and open Devtools on any page.
(2)Dock the Devtools to the bottom, open Resources tab and expand elements until a scrollbar is seen and select any element.
(3)Now undock the devtools into a seperate window and observe the focus on the selected element.

What is the expected result?
The focus on the selected element should be full.

What happens instead?
Some unwanted gap is seen on the focus.

This is a regression issue broken in M-50.

This issue is repro on Windows also.

Comment 1 by radhakri...@techmahindra.com, Mar 10 2016

Actual.mp4
1.3 MB Download
actual.png
213 KB View Download

Comment 2 by kavvaru@chromium.org, Mar 10 2016

Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
able to reproduce the reproduce the issue on windows 7 using chrome version 50.0.2661.26 it is wokring fine on Mac 10.11.3.

Radha@ Please provide the bisect infromation

Thanks,

Comment 3 by radhakri...@techmahindra.com, Mar 10 2016

Labels: -Needs-Bisect hasbisect
Owner: cbiesin...@chromium.org
Status: Assigned (was: Untriaged)
Good Build: 50.0.2660.0
Bad Build : 50.0.2661.0

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/19c030e8689cd94f5bc43fcce349e86e4d1ea405..8a3777d77af8e154f4eb03bfa87a8c73b58fa880

Suspecting https://codereview.chromium.org/1734203002 from changelog.

@cbiesinger: Please look into the issue and confirm whether it is worth a fix.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb25cec59deb052604d63036f1c5baf6efd2a5c

commit fbb25cec59deb052604d63036f1c5baf6efd2a5c
Author: cbiesinger <cbiesinger@chromium.org>
Date: Fri Mar 18 20:40:05 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}

[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 6 by cbiesin...@chromium.org, Mar 18 2016

Status: Fixed (was: Assigned)
merge request in  bug 594465
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 21 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4a99dd2428b2395fff7db0330a4c9280054162

commit 7f4a99dd2428b2395fff7db0330a4c9280054162
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Mon Mar 21 20:04:39 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}
(cherry picked from commit fbb25cec59deb052604d63036f1c5baf6efd2a5c)

Review URL: https://codereview.chromium.org/1819993002 .

Cr-Commit-Position: refs/branch-heads/2661@{#324}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 10 by ssamanoori@chromium.org, Mar 22 2016

Labels: TE-Verified-50.0.2661.48 TE-Verified-M50
Tested the issue on Windows 7, Ubuntu 14.04 using 50.0.2661.48.Observed that the focus on the selected element is full.
Please find attached screencast.

Marking it as TE-Verified.
593624.mp4
1.2 MB Download
►

Sign in to add a comment