Issue metadata
Sign in to add a comment
|
Regression: [MD] Tab focus does not travel to download shelf.
Reported by
rk...@etouch.net,
Mar 10 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2672.0 Revision b4fd57023ade2863e463d3380456968dca6c8bcf-refs/heads/master@{#380022}(32/64 bit) OS: Windows(Win-7 Aero Enabled),Linux Precondition: Enable 'Material design in the browser's top chrome' by selecting 'Material' option. What steps will reproduce the problem? (1) Launch chrome,navigate to http://www.orimi.com/pdf-test.pdf (2) Click on download icon and press Tab key and observe focus travel. Tab focus is not seen download shelf i.e. on 'Show All' button. Tab focus should seen on download shelf. This is a regression issue,broken in 'M-51' below is bisect info: Good Build: 51.0.2671.0 Bad Build: 51.0.2672.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/1f9673dbd1b71cfa5a0dc5ab06509368153bcb20..1e43e0d8e6dc2ec7c73a2587d21c079663e89159?pretty=fuller&n=10 Suspecting: r379998
,
Mar 15 2016
Able to reproduce the issue on windows 7 using chrome version 51.0.2679.0. estade@Could you please look into this issue if it is related to your change,else please route this to an appropriate dev person. Thanks,
,
Mar 15 2016
,
Mar 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46 commit 603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46 Author: estade <estade@chromium.org> Date: Wed Mar 16 01:07:17 2016 MD text buttons - implement focus ring. BUG= 571500 , 593614 Review URL: https://codereview.chromium.org/1800973002 Cr-Commit-Position: refs/heads/master@{#381377} [modify] https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46/ui/gfx/geometry/insets.cc [modify] https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46/ui/gfx/geometry/insets_f.cc [modify] https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46/ui/gfx/geometry/insets_f.h [modify] https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/603bbeb5d9a92d49141dbe1c4b0f511f3e41ca46/ui/views/controls/button/md_text_button.h
,
Mar 18 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 10 2016