New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593607 link

Starred by 12 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 596209
issue 597053
issue 600895
issue 662134

Blocking:
issue 561879



Sign in to add a comment

Move web-platform features in content/{child,renderer} to Blink's platform/ using Mojo

Project Member Reported by haraken@chromium.org, Mar 10 2016

Issue description

This is a tracking bug for the Blink-with-Mojo stuff in the Onion Soup project.

Our goals are:

- Make Blink directly talk with Mojo.
- Convert the old chromium IPC in content/{child,renderer} to Mojo.
- Migrate web-platform features in content/{child,renderer} to Blink's platform/.

yukishiino's presentation: https://docs.google.com/presentation/d/1HAzSSlLqcMl7TsJFqhy-gXx4TfsAygOLfm7aOY7DoU4/edit#slide=id.p

List of web-platform features: https://docs.google.com/spreadsheets/d/1VIINt17Dg2cJjPpoJ_HY3HI0uLpidql-1u8pBJtpbGk/edit#gid=1603373208

I welcome your contributions :)

 
@Yuki/haraken:
I am interested in moving the vr component for start. Anybody working on it or I can start looking into it?
Feel free to start working after writing your name on the spreadsheet :)

Thanks for contributing to this project.  AFAIK, no one is working on vr component.  Haraken@, do you know someone?
Thanks haraken/yuki for the update.
I will add my name in the spreadsheet and start working on vr. :)
Status: Started (was: Untriaged)
Just FYI, I changed the access permission of the sheet:
https://docs.google.com/spreadsheets/d/1VIINt17Dg2cJjPpoJ_HY3HI0uLpidql-1u8pBJtpbGk/edit#gid=160337320
so that "people with @chromium.org account can edit".

The previous setting was "everyone can comment" (even if they don't have @chromium.org account) so that everyone can access.  However it seemed too inconvenient, so I changed the access settings.

To those who don't have a @chromium.org account, please let me know so that I can grant you the access permission.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33515e2d141a9e16e2430136a80369f3376292b4

commit 33515e2d141a9e16e2430136a80369f3376292b4
Author: sammc <sammc@chromium.org>
Date: Wed Mar 30 20:41:54 2016

Change the battery-status layout tests to use JS mocks.

BUG= 597465 ,593607

Review URL: https://codereview.chromium.org/1836203002

Cr-Commit-Position: refs/heads/master@{#384082}

[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/api-defined-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/api-defined.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-promises-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-promises.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-windows-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/multiple-windows.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/page-visibility-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/page-visibility.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners.html
[add] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/LayoutTests/resources/mojo-helpers.js
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/Source/modules/battery/BatteryDispatcher.h
[delete] https://crrev.com/1f6dc1b24dfb56e0199b851f1c121195e33f2bd6/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp
[delete] https://crrev.com/1f6dc1b24dfb56e0199b851f1c121195e33f2bd6/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.h
[delete] https://crrev.com/1f6dc1b24dfb56e0199b851f1c121195e33f2bd6/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.idl
[modify] https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88f961ed0a8796a52bf9783b18ae116c8e324876

commit 88f961ed0a8796a52bf9783b18ae116c8e324876
Author: lukasza <lukasza@chromium.org>
Date: Thu Mar 31 00:03:18 2016

Revert of Change the battery-status layout tests to use JS mocks. (patchset #4 id:80001 of https://codereview.chromium.org/1836203002/ )

Reason for revert:
This CL caused 100 layout tests to crash when run with --site-per-process - see
 https://crbug.com/599297 

Original issue's description:
> Change the battery-status layout tests to use JS mocks.
>
> BUG= 597465 ,593607
>
> Committed: https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4
> Cr-Commit-Position: refs/heads/master@{#384082}

TBR=yukishiino@chromium.org,timvolodine@chromium.org,jam@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 597465 ,593607

Review URL: https://codereview.chromium.org/1844033004

Cr-Commit-Position: refs/heads/master@{#384147}

[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/api-defined-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/api-defined.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-promises-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-promises.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-windows-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/multiple-windows.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/page-visibility-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/page-visibility.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners.html
[delete] https://crrev.com/672a4cf2d22d8d5d2130687e7465dbce822a3425/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/LayoutTests/resources/mojo-helpers.js
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/Source/modules/battery/BatteryDispatcher.h
[add] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp
[add] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.h
[add] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.idl
[modify] https://crrev.com/88f961ed0a8796a52bf9783b18ae116c8e324876/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d2ac27f7ea8f6e54de319baee30754a26e5ac1

commit 77d2ac27f7ea8f6e54de319baee30754a26e5ac1
Author: sammc <sammc@chromium.org>
Date: Thu Mar 31 07:12:00 2016

Change the battery-status layout tests to use JS mocks.

BUG= 597465 ,593607

Committed: https://crrev.com/33515e2d141a9e16e2430136a80369f3376292b4
Cr-Commit-Position: refs/heads/master@{#384082}

Review URL: https://codereview.chromium.org/1836203002

Cr-Commit-Position: refs/heads/master@{#384207}

[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/api-defined-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/api-defined.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-promises-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-promises.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-windows-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/multiple-windows.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/page-visibility-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/page-visibility.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners-expected.txt
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners.html
[add] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/LayoutTests/resources/mojo-helpers.js
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/Source/modules/battery/BatteryDispatcher.h
[delete] https://crrev.com/76ff0ce0d70c76a955d4d3a94cac1bcbb585d1cf/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp
[delete] https://crrev.com/76ff0ce0d70c76a955d4d3a94cac1bcbb585d1cf/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.h
[delete] https://crrev.com/76ff0ce0d70c76a955d4d3a94cac1bcbb585d1cf/third_party/WebKit/Source/modules/battery/testing/InternalsBattery.idl
[modify] https://crrev.com/77d2ac27f7ea8f6e54de319baee30754a26e5ac1/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd191dc45a3114ffbe1305b38b27e19b91a32c7

commit fcd191dc45a3114ffbe1305b38b27e19b91a32c7
Author: sammc <sammc@chromium.org>
Date: Fri Apr 01 10:03:03 2016

Move geolocation and permission mojoms into WebKit/public/platform.

BUG=593607, 596209
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1771743002

Cr-Commit-Position: refs/heads/master@{#384536}

[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/DEPS
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chrome/browser/push_messaging/push_messaging_service_impl.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/DEPS
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_context.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_context.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/geolocation/geolocation_service_impl.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_context.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/child/permissions/permission_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/common/BUILD.gn
[delete] https://crrev.com/4d2a651896cbc5c01de890fefc05e1a8e61eddbe/content/common/geolocation_service.mojom
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/public/browser/permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/public/common/BUILD.gn
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/geolocation_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/geolocation_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/media_permission_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/media/midi_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/notification_permission_dispatcher.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_message_filter.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_message_filter.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_notification_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/layout_test/layout_test_push_messaging_service.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/common/layout_test/layout_test_messages.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/test/mock_permission_manager.cc
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/content/test/mock_permission_manager.h
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/blink.gyp
[add] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/geolocation/OWNERS
[rename] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/geolocation/geolocation.mojom
[modify] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/permissions/OWNERS
[rename] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/permissions/permission.mojom
[rename] https://crrev.com/fcd191dc45a3114ffbe1305b38b27e19b91a32c7/third_party/WebKit/public/platform/modules/permissions/permission_status.mojom

Blockedon: 600895
Project Member

Comment 11 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9519542992a024e3c90c29b25c00d8bd87e71480

commit 9519542992a024e3c90c29b25c00d8bd87e71480
Author: r.kasibhatla <r.kasibhatla@samsung.com>
Date: Fri May 06 20:43:59 2016

[OnionSoup] Moving VR service from content to Blink

Migrate vr service from content/renderer to third_party/WebKit/Source/modules.

This CL removes the files
 - content/renderer/vr/vr_dispatcher.*
 - WebKit/public/platform/modules/vr/WebVRClient.h
since functionality is folded into WebKit/Source/modules/vr/VRController.h.*

This CL also moves the files
 - content/renderer/vr/vr_type_converters.* to
WebKit/Source/modules/vr/VRTypeConverters.h.*
 - content/common/vr_service.mojom to
WebKit/public/platform/modules/vr/vr_service.mojom

VRController has been modified to talk directly to the mojo service impl
in browser's render frame host.

* Plan to rewrite the mock service of vr/ for layout tests
based on JS-bindings of Mojo.
* Plan to fix unit tests present in chrome/browser using fake service.
* Plan to add unit tests in WebKit/Source/modules if required for
vr service using fake service.

BUG=593607

TESTS=NONE
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1808203005
Cr-Commit-Position: refs/heads/master@{#392144}

[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/DEPS
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/vr/android/cardboard/cardboard_vr_device.cc
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/vr/android/cardboard/cardboard_vr_device.h
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/vr/vr_device.h
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/vr/vr_device_manager.cc
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/browser/vr/vr_device_manager.h
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/common/BUILD.gn
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/content_renderer.gypi
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/renderer/BUILD.gn
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/content/renderer/render_frame_impl.h
[delete] https://crrev.com/cdf7d66f57d6e5c4a253cdff72d1b593697f1512/content/renderer/vr/vr_dispatcher.cc
[delete] https://crrev.com/cdf7d66f57d6e5c4a253cdff72d1b593697f1512/content/renderer/vr/vr_dispatcher.h
[delete] https://crrev.com/cdf7d66f57d6e5c4a253cdff72d1b593697f1512/content/renderer/vr/vr_type_converters.cc
[delete] https://crrev.com/cdf7d66f57d6e5c4a253cdff72d1b593697f1512/content/renderer/vr/vr_type_converters.h
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/modules.gypi
[add] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/DEPS
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h
[add] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/VRTypeConverters.cc
[add] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/modules/vr/VRTypeConverters.h
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/public/blink_headers.gypi
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/public/platform/modules/vr/OWNERS
[delete] https://crrev.com/cdf7d66f57d6e5c4a253cdff72d1b593697f1512/third_party/WebKit/public/platform/modules/vr/WebVRClient.h
[rename] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/public/platform/modules/vr/vr_service.mojom
[modify] https://crrev.com/9519542992a024e3c90c29b25c00d8bd87e71480/third_party/WebKit/public/web/WebFrameClient.h

@yuki/haraken:
I am planning to take up screen_orientation up next (blink migration using mojo).
Is anyone working on it? Document shows it available but was not sure whether the document is still kept actively getting updated or not. :)
I'm not aware of anyone working on it. Feel free to take it :)

Great. I will add my name against the component in the document.
Any luck on screen orientation? :)
@esprehn:
Sorry couldn't work completely on the patch as was busy with other work.
I got the code ported to mojo IPC and moved it to blink/ from content/. Unit tests (and other tests) still pending.
Will upload the patch this week for review.
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f9646372b8297ec2bdc2d6d4e73962e29b4b184

commit 7f9646372b8297ec2bdc2d6d4e73962e29b4b184
Author: sammc <sammc@chromium.org>
Date: Fri Oct 14 04:16:21 2016

Add a blink InterfaceRegistry.

Currently, blink can use an InterfaceProvider to initiate communication
with a browser-implemented mojo interface. However, there is no way for
blink to directly provide mojo interfaces to the browser; instead there
must be some code in //content/renderer or //chrome/renderer to bridge
between the InterfaceRegistry there and blink. This CL adds a per-frame
InterfaceRegistry in blink that allows the browser to directly request
interfaces from blink.

BUG=593607

Review-Url: https://codereview.chromium.org/2401333002
Cr-Commit-Position: refs/heads/master@{#425250}

[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/content/renderer/BUILD.gn
[add] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/content/renderer/mojo/blink_interface_registry_impl.cc
[add] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/content/renderer/mojo/blink_interface_registry_impl.h
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/content/renderer/render_frame_impl.h
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/Source/platform/exported/InterfaceRegistry.cpp
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[add] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/public/platform/InterfaceRegistry.h
[modify] https://crrev.com/7f9646372b8297ec2bdc2d6d4e73962e29b4b184/third_party/WebKit/public/web/WebFrameClient.h

Blockedon: 662134
Components: Blink>Internals
Blockedon: 597053
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment