New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593596 link

Starred by 2 users
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Oct 2016
Cc:
█ trchen@chromium.org
pdr@chromium.org
jbroman@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 548184


Sign in to add a comment

[SPv2] PaintLayerPainter should adjust cull rect between transform spaces.

Project Member Reported by trchen@chromium.org, Mar 10 2016 
Some layout tests failed because a whole layer gets omitted due to wrong culling.

Including (but not limited to):
virtual/spv2/fast/overflow/overflow-update-transform.html
virtual/spv2/fast/overflow/scroll-nested-positioned-layer-in-overflow.html

Comment 1 by chrishtr@chromium.org, Mar 16 2016

Owner: chrishtr@chromium.org

Comment 2 by chrishtr@chromium.org, Mar 16 2016 

The plan is:

1. Disable culling temporarily to unblock property tree implementation work (trchen).
2. Implement GeometryMapper for the PaintLayerClipper use-case (chrishtr).
3. Undo #1.

Comment 3 by trchen@chromium.org, Apr 8 2016

Cc: trchen@chromium.org
 Issue 601704  has been merged into this issue.

Comment 4 by pdr@chromium.org, Apr 9 2016

Owner: trchen@chromium.org
Assigning to trchen for step 1 of comment 2.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4136c471aa2c38eb335f684b031088f490dfb1a

commit d4136c471aa2c38eb335f684b031088f490dfb1a
Author: trchen <trchen@chromium.org>
Date: Fri Apr 22 04:10:21 2016

[SPv2] Disables paint layer culling

In SPv2, the cull rect generated by the layer clipper does not match the space
we paint in. We decided to punt it until the Web Page Geometries API is
implemented, so we can easily derive the cull rect from tree builder.

BUG= 593596 

Review URL: https://codereview.chromium.org/1809593002

Cr-Commit-Position: refs/heads/master@{#389026}

[modify] https://crrev.com/d4136c471aa2c38eb335f684b031088f490dfb1a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d4136c471aa2c38eb335f684b031088f490dfb1a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Comment 6 by chrishtr@chromium.org, Aug 12 2016

Owner: chrishtr@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e00ec86f8876f35268cae04aef4f59d66b2d289

commit 6e00ec86f8876f35268cae04aef4f59d66b2d289
Author: chrishtr <chrishtr@chromium.org>
Date: Mon Sep 26 20:12:45 2016

Apply SVG root viewport clips in PaintLayerClipper.

This will not only improve the accuracy of the clip rects generated, but more
importantly, make clipping behavior in this class consistent with the clips
generated by SPv2 paint property trees.

BUG= 593596 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2371523002
Cr-Commit-Position: refs/heads/master@{#420971}

[modify] https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289/third_party/WebKit/Source/core/layout/ClipRectsCache.h
[modify] https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[add] https://crrev.com/6e00ec86f8876f35268cae04aef4f59d66b2d289/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10f853ca30c391d679d7989dfc7b54d9ac78e177

commit 10f853ca30c391d679d7989dfc7b54d9ac78e177
Author: chrishtr <chrishtr@chromium.org>
Date: Wed Sep 28 03:07:35 2016

[SPv2] Set an overflowClip clip node if an element has contain: paint.

BUG= 593596 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2370403003
Cr-Commit-Position: refs/heads/master@{#421432}

[modify] https://crrev.com/10f853ca30c391d679d7989dfc7b54d9ac78e177/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/10f853ca30c391d679d7989dfc7b54d9ac78e177/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Comment 9 by chrishtr@chromium.org, Oct 4 2016

Blockedon: 548184
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902ab929046fdb09759d1601bd430fdb64b2235c

commit 902ab929046fdb09759d1601bd430fdb64b2235c
Author: chrishtr <chrishtr@chromium.org>
Date: Thu Oct 06 23:24:05 2016

Use GeometryMapper to implement PaintLayerClipper.

BUG= 593596 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2238883006
Cr-Commit-Position: refs/heads/master@{#423731}

[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/layout/ClipRect.h
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/testing/Internals.cpp

Comment 11 by chrishtr@chromium.org, Oct 7 2016

Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/902ab929046fdb09759d1601bd430fdb64b2235c

commit 902ab929046fdb09759d1601bd430fdb64b2235c
Author: chrishtr <chrishtr@chromium.org>
Date: Thu Oct 06 23:24:05 2016

Use GeometryMapper to implement PaintLayerClipper.

BUG= 593596 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2238883006
Cr-Commit-Position: refs/heads/master@{#423731}

[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/layout/ClipRect.h
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/902ab929046fdb09759d1601bd430fdb64b2235c/third_party/WebKit/Source/core/testing/Internals.cpp

Comment 13 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment