New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593593 link

Starred by 1 user
Status: Fixed
Owner:
cbiesin...@chromium.org
Closed: Mar 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted white space is seen in 'Sources' section of devtools.

Reported by mni...@etouch.net, Mar 10 2016 
Chrome version :51.0.2672.0 b4fd57023ade2863e463d3380456968dca6c8bcf-refs/heads/master@{#380022} (32/64 bit)
OS : All(Win 7 aero enabled).

Steps : 
1. Launch Chrome and open NTP and open devtools
2. Now go to 'Sources' section and click on 'Event Listener Breakpoints' arrow icon and drop down list will be opened and scroll bar will be displayed
3. Now again click on 'Event Listener Breakpoints' arrow icon and observe the (RHS)area of scroll bar


Actual : Unwanted white space is seen on RHS after opening and closing 'Event Listener Breakpoints' drop down list
Expected : Unwanted white space should not be seen

This is a regression issue broken in 'M-50' and below is the manual regression and narrow bisect info:
Good build : 50.0.2660.3
Bad build : 50.0.2661.0

Narrow bisect :
https://chromium.googlesource.com/chromium/src/+log/19c030e8689cd94f5bc43fcce349e86e4d1ea405..8a3777d77af8e154f4eb03bfa87a8c73b58fa880?pretty=fuller&n=50

Suspecting : r377826 from Narrow bisect.

@cbiesinger : Could you please help to reassign if your change is not the cause for this change.
Actual_video.mp4
312 KB Download
Expected_video.mp4
601 KB Download
Actual_screenshot.png
123 KB View Download
Expected_screenshot.png
110 KB View Download

Comment 1 by mni...@etouch.net, Mar 10 2016

Summary: Regression : Unwanted white space is seen in 'Sources' section of devtools. (was: Regression : Unwanted white space is seen on RHS after opening and closing 'Event Listener Breakpoints' drop down list.)

Comment 2 by ranjitkan@chromium.org, Mar 10 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by kavvaru@chromium.org, Mar 14 2016 

Just to update ,
Issue is reproducible on windows 7 using chrome latest canary version 51.0.2677.0.
cbiesinger@ Could you please look into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb25cec59deb052604d63036f1c5baf6efd2a5c

commit fbb25cec59deb052604d63036f1c5baf6efd2a5c
Author: cbiesinger <cbiesinger@chromium.org>
Date: Fri Mar 18 20:40:05 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}

[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/fbb25cec59deb052604d63036f1c5baf6efd2a5c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 7 by cbiesin...@chromium.org, Mar 18 2016

Status: Fixed (was: Assigned)
merge request in  bug 594465

Comment 8 by cbiesin...@chromium.org, Mar 18 2016 

merge request in  bug 594465
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f4a99dd2428b2395fff7db0330a4c9280054162

commit 7f4a99dd2428b2395fff7db0330a4c9280054162
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Mon Mar 21 20:04:39 2016

Set m_{width,height}AvailableToChildrenChanged when scrollbars appear

This is a regression from https://codereview.chromium.org/1734203002. Before
that change, we'd just call layoutBlock(true). However, the new approach
just marks for layout and eventually recurses down, so to ensure that
the children get laid out, we have to set
m_{width,height}AvailableToChildrenChanged.

BUG= 594465 , 593593 , 590683 , 593624 , 593593 

Review URL: https://codereview.chromium.org/1811753003

Cr-Commit-Position: refs/heads/master@{#382074}
(cherry picked from commit fbb25cec59deb052604d63036f1c5baf6efd2a5c)

Review URL: https://codereview.chromium.org/1819993002 .

Cr-Commit-Position: refs/branch-heads/2661@{#324}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-abspos.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes-expected.html
[add] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/LayoutTests/css3/flexbox/overflow-auto-dynamic-changes.html
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/7f4a99dd2428b2395fff7db0330a4c9280054162/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 12 by ssamanoori@chromium.org, Mar 22 2016

Labels: TE-Verified-50.0.2661.48 TE-Verified-M50
Tested the issue on Windows 7, Mac 10.10.5, Ubuntu 14.04 using 50.0.2661.48.Observed that unwanted white space is not seen on RHS after opening and closing 'Event Listener Breakpoints' drop down list.
Please find attached screencast.

Marking it as TE-Verified.

Comment 13 by ssamanoori@chromium.org, Mar 22 2016

593593.png
118 KB View Download
►

Sign in to add a comment