New issue
Advanced search Search tips

Issue 593591 link

Starred by 2 users
Status: Fixed
Owner:
thestig@chromium.org
Closed: Mar 2016
Cc:
m...@chromium.org
chrishall@chromium.org
grunell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Chromium Windows Builder (DrMemory x64) failing the compile step

Project Member Reported by thestig@chromium.org, Mar 10 2016 
With https://chromium.googlesource.com/chromium/src/+/cfbc8cb058dcc6cf88f1c4d70c8eb76652c39123 the Chromium Windows Builder (DrMemory x64) bot failed: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%20x64%29/builds/865

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True content_unittests.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:content_unittests.exe @content_unittests.exe.rsp" 1 mt.exe rc.exe "obj\content\content_unittests.content_unittests.exe.intermediate.manifest" obj\content\content_unittests.content_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest
content_unittests.webrtc_local_audio_track_adapter_unittest.obj : error LNK2019: unresolved external symbol "private: __cdecl content::MediaStreamAudioLevelCalculator::Level::~Level(void)" (??1Level@MediaStreamAudioLevelCalculator@content@@AEAA@XZ) referenced in function "private: static void __cdecl scoped_refptr<class content::MediaStreamAudioLevelCalculator::Level>::Release(class content::MediaStreamAudioLevelCalculator::Level *)" (?Release@?$scoped_refptr@VLevel@MediaStreamAudioLevelCalculator@content@@@@CAXPEAVLevel@MediaStreamAudioLevelCalculator@content@@@Z)

content_unittests.exe : fatal error LNK1120: 1 unresolved externals

Comment 1 by thestig@chromium.org, Mar 10 2016 

Chromium Windows Builder (DrMemory) is failing as well: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%29/builds/16206

FWIW, the bot builds with: GYP_DEFINES=build_for_tool=drmemory component=shared_library

Comment 2 by thestig@chromium.org, Mar 10 2016

Cc: grunell@chromium.org
I'm guessing the content::MediaStreamAudioLevelCalculator::Level class is missing a CONTENT_EXPORT ??
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0f58d4aab12dc80cf372899966ecfe652499910

commit e0f58d4aab12dc80cf372899966ecfe652499910
Author: thestig <thestig@chromium.org>
Date: Thu Mar 10 07:15:46 2016

Add CONTENT_EXPORT for content::MediaStreamAudioLevelCalculator::Level.

This is a speculative fix.

BUG= 593591 
TBR=miu@chromium.org,grunell@chromium.org

Review URL: https://codereview.chromium.org/1778283002

Cr-Commit-Position: refs/heads/master@{#380367}

[modify] https://crrev.com/e0f58d4aab12dc80cf372899966ecfe652499910/content/renderer/media/media_stream_audio_level_calculator.h

Comment 4 by thestig@chromium.org, Mar 10 2016

Cc: m...@chromium.org
Owner: thestig@chromium.org
Status: Fixed (was: Untriaged)
Green: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%29/builds/16209
►

Sign in to add a comment