GN: Support generate of dSYM |
||||||
Issue descriptionThis will be required for release builds.
,
Jun 21 2016
This is not yet integrated on iOS and this is required for official build, so reopening just for iOS.
,
Jul 1 2016
,
Jul 15 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 18 2016
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e714433f6749c3664ca816d1c64a488828ef75d commit 6e714433f6749c3664ca816d1c64a488828ef75d Author: sdefresne <sdefresne@chromium.org> Date: Tue Jul 19 12:41:58 2016 [iOS/GN] Fix generation of .dSYM for fat binary builds. When creating fat binaries, the generation of the .dSYM file need to use the fat binary and not the intermediate binaries. So for a fat build, //build/config/mac:strip_all is an empty configuration and the linker tools do not pass the flag requesting generation of the .dSYM file to linker_driver.py, instead the flags are passed when "lipo" is invoked. Fix //build/toolchain/mac/linker_driver.py to look for both "-o" and "-output" when looking for the linker output to allow wrapping "lipo" in addition to the compiler linker (as "lipo" only accept "-output" flag to specify the output file). Always add //build/config/mac:strip_all to the dependencies of all linkable targets on iOS (as is done on Mac) and fix cronet. BUG= 593582 Review-Url: https://codereview.chromium.org/2160653002 Cr-Commit-Position: refs/heads/master@{#406253} [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/build/config/BUILDCONFIG.gn [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/build/config/ios/rules.gni [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/build/config/mac/BUILD.gn [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/build/config/mac/base_rules.gni [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/build/toolchain/mac/BUILD.gn [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/build/toolchain/mac/linker_driver.py [modify] https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d/components/cronet/ios/BUILD.gn
,
Jul 19 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpranke@chromium.org
, Jun 21 2016