New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593555 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Chrome crashes with "disable-sync" flag set

Reported by kra...@amazon.com, Mar 10 2016

Issue description

Version: Tip of master
OS: Tested on Android, but most likely all of them

What steps will reproduce the problem?
On Android:
(1) build/android/adb_chrome_public_command_line --disable-sync
(2) Launch Chrome Public
[In case it hasn't crashed by now: Open a new tab page]

What is the expected output? What do you see instead?
Expected: Everything works
Actual: Browser crashes
V/CrashDescriptorUtil(  931): backtrace:
V/CrashDescriptorUtil(  931):     #00  pc 002166e2  /data/app-lib/org.chromium.chrome-2/libchrome_public.cr.so
V/CrashDescriptorUtil(  931):     #01  pc 0021672f  /data/app-lib/org.chromium.chrome-2/libchrome_public.cr.so (Java_org_chromium_chrome_browser_profiles_MostVisitedSites_nativeInit+46)

Please use labels and text to provide additional information.
This seems to be caused by this commit:
https://chromium.googlesource.com/chromium/src/+/9572aaf2cd0bd8172489ac0daab3d07e56c9db15%5E%21/#F0
Which removed two null-checks in most_visited_sites.cc

 
Components: UI>Browser>NewTabPage

Comment 2 by fi...@chromium.org, Jul 29 2016

Labels: zine-articles-v1 zine-triaged
Owner: treib@chromium.org
Status: Assigned (was: Untriaged)
treib, can you check that pls?

Comment 3 by treib@chromium.org, Jul 29 2016

Labels: -zine-articles-v1 zine-ntp OS-Android
Sure, I'll take a look.
most_visited_sites.cc is only used on Android so far, so if that's indeed the cause, then it's Android-only.

Comment 4 by treib@chromium.org, Aug 1 2016

Status: WontFix (was: Assigned)
I can't reproduce this, I assume it's been fixed in the meantime: MostVisitedSites hasn't used Sync directly since
https://chromium.googlesource.com/chromium/src/+/16070ce69cfb26481240995705c8a1a206fd829c
which landed 1 day after this bug was filed :D

Sign in to add a comment