New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593547 link

Starred by 1 user
Status: Fixed
Owner:
juncai@chromium.org
Closed: Mar 2016
Cc:
█ n...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Use NoUnderlineClickableSpan instead of overriding ClickableSpan::updateDrawState using textPaint.setUnderlineText(false)

Project Member Reported by juncai@chromium.org, Mar 10 2016 
A new class NoUnderlineClickableSpan which shows a clickable link with underlines turned off was added in patch:
https://codereview.chromium.org/1739523002/

So code use ClickableSpan which overrides its
updateDrawState(TextPaint textPaint) function with:
textPaint.setUnderlineText(false);
can re-use this new class.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/674521d2e65100457ab1281403091c1b7bf97a29

commit 674521d2e65100457ab1281403091c1b7bf97a29
Author: juncai <juncai@chromium.org>
Date: Fri Mar 25 21:07:16 2016

Re-use NoUnderlineClickableSpan which shows a clickable link with underlines turned off

A new class NoUnderlineClickableSpan which shows a
clickable link with underlines turned off was added in
patch:
https://codereview.chromium.org/1739523002/

This patch modified code which can re-use this class.

BUG= 593547 

Review URL: https://codereview.chromium.org/1774243003

Cr-Commit-Position: refs/heads/master@{#383359}

[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java
[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchOptOutPromo.java
[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
[modify] https://crrev.com/674521d2e65100457ab1281403091c1b7bf97a29/chrome/android/java/src/org/chromium/chrome/browser/tab/SadTabViewFactory.java

Comment 2 by juncai@chromium.org, Mar 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment