New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593543 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

Toolbar top stroke needs to be aligned with the tab stroke

Project Member Reported by sgabr...@chromium.org, Mar 10 2016

Issue description

This is mostly noticeable when the window is inactive but there is a disconnection between the stroke drawn on the tabs and on the toolbar. The toolbar one is too light.

As mentioned the issue is mostly noticeable on light background or when the window is inactive. Biggest point of issue is where the tab strokes meets the toolbar stroke.


 
stroke-current-active.png
13.7 KB View Download
inactive-1.png
6.3 KB View Download
inactive 2.png
4.9 KB View Download
stroke-expected.png
12.2 KB View Download
A better preview of an entire tab. 
On this background, tab stroke renders at #AEAEAE. Toolbar stroke renders at #D4D4D4.
Attaching the image for #1 for real.
preview-entire tab.png
19.9 KB View Download

Comment 3 by shrike@chromium.org, Mar 10 2016

I vaguely remember some issue that drove me to stroke the tabs one way and the top of the tab strip another. I will take a look at the code.

Comment 4 by shrike@chromium.org, Mar 22 2016

Blocking: 547953
Components: UI>Browser>Core
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b7c86c24e1ec488be51eb6e623d53a7276dafb8

commit 0b7c86c24e1ec488be51eb6e623d53a7276dafb8
Author: shrike <shrike@chromium.org>
Date: Tue Apr 05 23:12:19 2016

[Mac] Use correct stroke color for toolbar top edge in Material Design.

The toolbar top edge stroke color has the wrong alpha value for
Material Design.

R=estade@chromium.org
BUG= 593543 

Review URL: https://codereview.chromium.org/1863483005

Cr-Commit-Position: refs/heads/master@{#385318}

[modify] https://crrev.com/0b7c86c24e1ec488be51eb6e623d53a7276dafb8/chrome/browser/themes/theme_properties.cc

Status: Fixed (was: Started)

Sign in to add a comment