New issue
Advanced search Search tips

Issue 593541 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

angle_perftests failure on chromium.perf win7 gpu bots at #379936:#380001

Project Member Reported by robert...@chromium.org, Mar 10 2016

Issue description

Revision range first seen: #379936:#380001
Link to failing step log:
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf%20%282%29/builds/4706/steps/angle_perftests/logs/stdio

This is consistently failing in Win7 Ati and Win7 Nvidia

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3be43be0bbb1b8f32f7e6c42d06f5b0a1f1ee467

commit 3be43be0bbb1b8f32f7e6c42d06f5b0a1f1ee467
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Mar 10 01:05:08 2016

Fix crash in IndexDataManagerPerfTest.

Using a mock BufferFactory would sometimes leave us with a nullptr in
the VertexBufferInterface class. This would lead to a null deref in
the perf tests only. Fix this by adding a null check.

BUG= 593541 

Change-Id: I98685a9990124f521cd26ed81a26aeb11aafaf0d
Reviewed-on: https://chromium-review.googlesource.com/331768
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/3be43be0bbb1b8f32f7e6c42d06f5b0a1f1ee467/src/libANGLE/renderer/d3d/VertexBuffer.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345ac09508fed90c9a8e9abf75174e1cbe858c09

commit 345ac09508fed90c9a8e9abf75174e1cbe858c09
Author: robertocn <robertocn@chromium.org>
Date: Thu Mar 10 05:42:08 2016

Disabling angle_perftests for Win7 (ATI + Nvidia).

BUG= 593541 
TBR=eakuefner,fmeawad

Review URL: https://codereview.chromium.org/1777853004

Cr-Commit-Position: refs/heads/master@{#380342}

[modify] https://crrev.com/345ac09508fed90c9a8e9abf75174e1cbe858c09/testing/buildbot/chromium.perf.json

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4146624afda978a7f78e81eac9ac613d488f4827

commit 4146624afda978a7f78e81eac9ac613d488f4827
Author: jmadill <jmadill@chromium.org>
Date: Thu Mar 10 15:43:57 2016

Roll ANGLE b5abec3..bd38271

https://chromium.googlesource.com/angle/angle.git/+log/b5abec3..bd38271

BUG= 593541 
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1780463006

Cr-Commit-Position: refs/heads/master@{#380414}

[modify] https://crrev.com/4146624afda978a7f78e81eac9ac613d488f4827/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7182455e864116aaedfe3fc6c76ca6df93c9714f

commit 7182455e864116aaedfe3fc6c76ca6df93c9714f
Author: jmadill <jmadill@chromium.org>
Date: Thu Mar 10 16:12:24 2016

Revert of Disabling angle_perftests for Win7 (ATI + Nvidia). (patchset #1 id:1 of https://codereview.chromium.org/1777853004/ )

Reason for revert:
ANGLE roll landed which fixes the crash.

Original issue's description:
> Disabling angle_perftests for Win7 (ATI + Nvidia).
>
> BUG= 593541 
> TBR=eakuefner,fmeawad
>
> Committed: https://crrev.com/345ac09508fed90c9a8e9abf75174e1cbe858c09
> Cr-Commit-Position: refs/heads/master@{#380342}

TBR=eakuefner@chromium.org,fmeawad@chromium.org,robertocn@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 593541 

Review URL: https://codereview.chromium.org/1780963002

Cr-Commit-Position: refs/heads/master@{#380417}

[modify] https://crrev.com/7182455e864116aaedfe3fc6c76ca6df93c9714f/testing/buildbot/chromium.perf.json

Status: Fixed (was: Untriaged)
The benchmark hasn't failed on the bot for more than a week (last failure: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf%20%282%29/builds/4723 ). Therefore, I'm marking this issue as fixed. Please re-open if the failures occur again.

Sign in to add a comment