New tab button rendering could be improved |
|||||
Issue descriptionSorry if that's already on your list or currently being fixed. The New tab button could use some improvement. Strokes are too strong, rounded corners are too rounded. Shadowing looks weird in incognito.
,
Mar 22 2016
,
May 6 2016
,
May 10 2016
Looking at expected.png, the fill color looks like the foreground tab fill color but here are specs received from sgabriel@ on 11/4/15: Active window Active tab + toolbar = #F2F2F2 Inactive tab + new tab button = #DADADA Inactive window Active tab + toolbar = #F6F6F6 Inactive tab + new tab button = #ECECEC That's at least why my button fill color is darker. sgabriel@ - for the hover state I am drawing the normal color and then overlaying a transparent white on it. Can you tell me the specs for that highlight (in normal and Incognito modes)? For the pressed state it looks like I am just drawing the button as normal. I don't know if there should be a highlight in that case (the button performs its action the moment you click it so you barely see a change as it is).
,
May 11 2016
What I told you on 11/4/15 is correct. Sometimes previews might not match. Regarding the hover: It was initially designed as a 20% opaque #FFF layer on top of the theming. This is not set in stone as we might want to play with how prominent it looks. Pressed: Initially designed to replace the theming by a single 8% opaque #000 layer + inner shadows. See preview attached. These specs apply to both normal and incognito mode. Again these are not set in stone as the OSX frame works differently from Cros and windows so we should use best judgement.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b20049f3e4405bbe7e7ca2e0184777bc1a331c2 commit 6b20049f3e4405bbe7e7ca2e0184777bc1a331c2 Author: shrike <shrike@chromium.org> Date: Thu May 12 03:50:13 2016 [Mac][Material Design] Fix the new tab button's path. This cl refines the new tab button's vector path to match the spec. It also cleans up the appearance of the hover and pressed states. R=avi@chromium.org BUG= 593535 Review-Url: https://codereview.chromium.org/1967693002 Cr-Commit-Position: refs/heads/master@{#393172} [modify] https://crrev.com/6b20049f3e4405bbe7e7ca2e0184777bc1a331c2/chrome/browser/ui/cocoa/new_tab_button.mm
,
May 12 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shrike@chromium.org
, Mar 10 2016