More clear error needed "Missing LGTM from OWNERS of dependencies added to DEPS" |
|||||
Issue descriptionI can't land this CL: https://codereview.chromium.org/1747783002/ beacause of chrome/browser/android/DEPS modification even after two LGTMS from dtrainor@ who is an OWNER in chrome/browser/android/
,
Mar 11 2016
,
Mar 11 2016
As clarified by loyso, "You need someone from CC because you're adding that as a dependency. They have to approve you depending on them." is a message from the chat, not a suggested text. IMHO, "Missing LGTM from OWNERS of dependencies added to DEPS" is already clear, but perhaps we can make it even more clear by adding Please ask OWNERs of added dependencies to review this CL. in the end?
,
Mar 11 2016
After some further offline discussion with loyso, we think we should change this to:
** Presubmit ERRORS **
You need LGTM from owners of depends-on paths in DEPS that were modified in this CL:
'+cc/layers/layer_settings.h',
,
Mar 14 2016
,
Apr 26 2016
,
Jul 4 2016
,
Jul 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec17f88453662349b4ab73a51cf74bd416eca2da commit ec17f88453662349b4ab73a51cf74bd416eca2da Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Mon Jul 04 14:16:15 2016 Improve handling of DEPS OWNERS PRESUBMIT check BUG= 593533 Review URL: https://codereview.chromium.org/2120283002 . Cr-Commit-Position: refs/heads/master@{#403680} [modify] https://crrev.com/ec17f88453662349b4ab73a51cf74bd416eca2da/PRESUBMIT.py
,
Jul 4 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by loyso@chromium.org
, Mar 11 2016Summary: More clear error needed "Missing LGTM from OWNERS of dependencies added to DEPS" (was: "Missing LGTM from OWNERS of dependencies added to DEPS" after LGTM from OWNER)
** Presubmit ERRORS ** Missing LGTM from OWNERS of dependencies added to DEPS: '+cc/layers/layer_settings.h', "You need someone from CC because you're adding that as a dependency. They have to approve you depending on them." It doesn't explain that you need a CC OWNER LGTM. More clear message needed. And suggested reviewers.