New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593525 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 591199



Sign in to add a comment

Implement table walk in PaintPropertyTreeBuilder.

Project Member Reported by trchen@chromium.org, Mar 10 2016

Issue description

I left a TODO in there about investigating table paint offset computation. Turns out there are indeed some cases that box offset gets counted twice.
 
Summary: Implement table walk in PaintPropertyTreeBuilder. (was: [SPv2] Implement table walk in PaintPropertyTreeBuilder.)
This is also needed by SPv1 new paint invalidation ( bug 591199 ).
Blocking: 591199
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0b4bc588c246586ffbb3fedc38444e674996913

commit f0b4bc588c246586ffbb3fedc38444e674996913
Author: trchen <trchen@chromium.org>
Date: Wed Mar 16 05:25:54 2016

[SPv2] Fix paint offset computation for LayoutTableCell in property tree builder

The table cells have a weird quirk. Although their layout container is the row,
are painted by the rows and can be affected by transforms on the row,
their layout location is relative to the table section.
(i.e. with the row's location baked-in)

This CL adjusts table cell's paint offset in property tree builder in the
same way as other layout/paint code does.

BUG= 593525 

Review URL: https://codereview.chromium.org/1805283002

Cr-Commit-Position: refs/heads/master@{#381397}

[modify] https://crrev.com/f0b4bc588c246586ffbb3fedc38444e674996913/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/f0b4bc588c246586ffbb3fedc38444e674996913/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Status: Fixed (was: Assigned)
I think this has been fixed.

Sign in to add a comment