New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593519 link

Starred by 0 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl format doesn't format untouched lines if their scope changed

Project Member Reported by loyso@chromium.org, Mar 9 2016

Issue description

Se this CL as an example:
https://codereview.chromium.org/1782433002/#ps1
(patchset#1)

-  if (layer_settings().use_compositor_animation_timelines) {
     AddAnimationToLayerWithPlayer(grand_child->id(), timeline_impl(),
                                   std::move(animation));
-  } else {
-    grand_child->layer_animation_controller()->AddAnimation(
-        std::move(animation));
-  }

AddAnimationToLayerWithPlayer line wouldn't be formatted.

I suspect, you need to parse C++ (in full) to implement this.


 
Components: -Infra Infra>SDK
Labels: Pri-3
Stale, dropping priority.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment