New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593495 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

/video_VideoDecodeMemoryUsage uses hardcoded path for exynos memory

Project Member Reported by marc...@chromium.org, Mar 9 2016

Issue description

This test has the following:

X86_GEM_OBJECTS_PATH = '/sys/kernel/debug/dri/0/i915_gem_objects'
ARM_GEM_OBJECTS_PATH = '/sys/kernel/debug/dri/0/exynos_gem_objects'

for one, this is open coded (there is shared code in graphics_utils.py which does memory reporting, it should be reused) and second it should also support other device nodes than 0.

 
Status: Assigned (was: Untriaged)
Components: OS>Kernel>Video
Labels: videoshortlist
Status: Untriaged (was: Assigned)

Comment 3 by vsu...@google.com, Jan 13 2017

Labels: OS-Chrome
Owner: owenlin@chromium.org
Status: Assigned (was: Untriaged)
Owen. Please take a look.
Owen. Any update?
Status: Started (was: Assigned)
Not look into the issue yet, will find sometime to do it now.
Status: Archived (was: Started)
Status: Assigned (was: Archived)
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15c4b3f3e036cdd7b4db2bbaa61884d0cfce22ea

commit 15c4b3f3e036cdd7b4db2bbaa61884d0cfce22ea
Author: Owen Lin <owenlin@google.com>
Date: Thu Mar 09 09:09:38 2017

video_VideoDecodeMemoryUsage: Use graphic_utils to get memory usage.

BUG= chromium:593495 
TEST=Run the test on peach_pi.

Change-Id: I4fac89b8ab612a83640990849e9b343a0ef39f16
Reviewed-on: https://chromium-review.googlesource.com/451168
Commit-Ready: Owen Lin <owenlin@chromium.org>
Tested-by: Owen Lin <owenlin@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/15c4b3f3e036cdd7b4db2bbaa61884d0cfce22ea/client/site_tests/video_VideoDecodeMemoryUsage/video_VideoDecodeMemoryUsage.py

Status: Fixed (was: Started)

Comment 12 by kcwu@chromium.org, May 11 2017

Issue 721274 has been merged into this issue.

Comment 13 by kcwu@chromium.org, May 11 2017

Labels: Merge-Request-58 Merge-Request-57
Status: Assigned (was: Fixed)
Cc: bhthompson@chromium.org
Labels: -videoshortlist
Labels: -Merge-Request-58 Merge-Approved-58
Approved for 58, but 57 is no longer active.
Project Member

Comment 17 by bugdroid1@chromium.org, May 17 2017

Labels: merge-merged-release-R58-9334.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fd3a76a022ff5e1875f22037d9558b9776ef88e6

commit fd3a76a022ff5e1875f22037d9558b9776ef88e6
Author: Owen Lin <owenlin@google.com>
Date: Wed May 17 01:52:37 2017

video_VideoDecodeMemoryUsage: Use graphic_utils to get memory usage.

BUG= chromium:593495 
TEST=Run the test on peach_pi.

Change-Id: I4fac89b8ab612a83640990849e9b343a0ef39f16
Reviewed-on: https://chromium-review.googlesource.com/451168
Commit-Ready: Owen Lin <owenlin@chromium.org>
Tested-by: Owen Lin <owenlin@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit 15c4b3f3e036cdd7b4db2bbaa61884d0cfce22ea)
Reviewed-on: https://chromium-review.googlesource.com/505863
Reviewed-by: Owen Lin <owenlin@chromium.org>
Commit-Queue: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/fd3a76a022ff5e1875f22037d9558b9776ef88e6/client/site_tests/video_VideoDecodeMemoryUsage/video_VideoDecodeMemoryUsage.py

Status: Fixed (was: Assigned)
Project Member

Comment 19 by sheriffbot@chromium.org, May 22 2017

Cc: bhthompson@google.com kcwu@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, May 26 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-57 -Merge-Approved-58 Merge-Merged
Labels: VerifyIn-61
Cc: avkodipelli@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment