New issue
Advanced search Search tips

Issue 593482 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 453893



Sign in to add a comment

Uncloseable tab occurs when oopifs are used with onbeforeunload handlers

Project Member Reported by nick@chromium.org, Mar 9 2016

Issue description

Chrome Version       : 51.0.2672.0 (Official Build) canary (64-bit)
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) : https://memegen.googleplex.com/create?selected_template=evilest_thing_i_can_imagine

This repro uses a Google-only URL, so apologies in advance.

What steps will reproduce the problem?
1. Launch chrome with the --site-per-process flag (enable it via chrome://flags/#enable-site-per-process)
2. Visit https://memegen.googleplex.com/create?selected_template=evilest_thing_i_can_imagine, which apparently contains a cross site iframe
3. Enter some text in the 'top text' text field.
4. Change the cursor focus to the 'middle text' text field.
5. Try to close the tab.

What is the expected result?
The user should see a 'confirm navigation' prompt and be able to close the tab.

What happens instead of that?
No prompt appears. The tab is unkillable but you can still interact with it, and it is not possible to reload the page or navigate anywhere else. Also, it is impossible to restart Chrome unless you first manually kill the process for this tab.

 
I wonder if the root cause of this is the same as  issue 453893 ?

Comment 2 by a...@chromium.org, Mar 9 2016

Probably? Javascript alerts and onbeforeunload alerts use a lot of the same machinery.

Comment 3 by creis@chromium.org, Apr 6 2016

Labels: Proj-IsolateExtensions-BlockingLaunch
Owner: a...@chromium.org
Status: Assigned (was: Available)
Avi, can you check if this gets fixed by your work on  issue 453893 ?  If not, we can triage it later.  I just don't want to forget about it.

Comment 4 by a...@chromium.org, Apr 7 2016

Blockedon: 453893
I'll check.

Comment 5 by a...@chromium.org, Apr 7 2016

Yes, the failure of JavaScript dialogs in  bug 453893  appears to be the cause, and the fix also fixes this.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b8dbb34625fc40457dcffc75ae0409176d843af

commit 6b8dbb34625fc40457dcffc75ae0409176d843af
Author: avi <avi@chromium.org>
Date: Fri Apr 08 18:59:35 2016

Fix JavaScript alerts from frames with oopif on, after a cross-process click.

BUG= 453893 , 593482 
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1849013004

Cr-Commit-Position: refs/heads/master@{#386158}

[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/browser/renderer_host/render_view_host_impl.h
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/common/frame_messages.h
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/common/view_messages.h
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/renderer/render_frame_impl.h
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/renderer/render_view_impl.cc
[modify] https://crrev.com/6b8dbb34625fc40457dcffc75ae0409176d843af/content/renderer/render_view_impl.h

Comment 7 by a...@chromium.org, Apr 8 2016

Status: Fixed (was: Assigned)

Sign in to add a comment