New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593470 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
█ robert...@chromium.org
dtu@chromium.org
sullivan@chromium.org
simonhatch@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Several false positives found by stats-based bisect

Project Member Reported by robert...@chromium.org, Mar 9 2016 
refer to go/badbisects for a list of examples.

General traits of these are:
- Small regression found,
- Bisect re-tests the reference range several times (> 25)
- An unrelated culrpit is found with only a tiny regression

We should tweak the constants we use to make bisect give up early in these cases.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/dc654f857ce393c4a26dea474fe7aa8c697a2803

commit dc654f857ce393c4a26dea474fe7aa8c697a2803
Author: robertocn@chromium.org <robertocn@chromium.org>
Date: Wed Mar 09 22:50:15 2016

Tweaking classifying algorithm constants to reduce false positives.

R=dtu
BUG= 593470 

Review URL: https://codereview.chromium.org/1780753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299196 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/bisector.py
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json
[modify] https://crrev.com/dc654f857ce393c4a26dea474fe7aa8c697a2803/scripts/slave/recipes/bisect.expected/basic.json
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/eba9f2047647330ebbd36bd565db4fcf8c1975f1

commit eba9f2047647330ebbd36bd565db4fcf8c1975f1
Author: robertocn@chromium.org <robertocn@chromium.org>
Date: Mon Mar 14 21:08:33 2016

Further reducing the max required samples.

Some cases have been observed where the bisect fails to give up after 18
samples.

R=dtu
BUG= 593470 

Review URL: https://codereview.chromium.org/1778233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299282 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/eba9f2047647330ebbd36bd565db4fcf8c1975f1/scripts/slave/recipe_modules/auto_bisect/bisector.py
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=85009

------------------------------------------------------------------
r85009 | recipe-roller@chromium.org | 2016-03-10T00:49:17.301141Z

-----------------------------------------------------------------

Comment 4 by robert...@chromium.org, Mar 22 2016

Cc: robert...@chromium.org
Labels: triaged
Owner: ----
Status: Available (was: Started)
Moving out of the queue for a while. Let's keep gathering samples.

Comment 5 by benhenry@chromium.org, Feb 3 2017

Components: Speed>Bisection

Comment 6 by benhenry@chromium.org, Feb 6 2017

Status: Fixed (was: Available)
►

Sign in to add a comment