New issue
Advanced search Search tips

Issue 593452 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Implement a way to queue sending feedback reports started within short intervals of each others

Project Member Reported by afakhry@chromium.org, Mar 9 2016

Issue description

Currently, if two feedback reports were requested to be sent successively within a very short time from each other, the first report might not be sent, and the second might be sent with the sys info of the first one.

We need to implement a way to queue both reports correctly.

 

Comment 1 by r...@chromium.org, Mar 9 2016

Labels: -Pri-2 Pri-1
Given that this has the potential to mislead developers with Feedback reports with incorrect logs (logs from the correct time for example, are super important to things like, for example, touchpad issues), I would say we need this for the current milestone.

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c678f28bc8b50041b8aaa700714c75cd02b19f4

commit 9c678f28bc8b50041b8aaa700714c75cd02b19f4
Author: afakhry <afakhry@chromium.org>
Date: Thu Mar 17 19:13:12 2016

Fix sending multiple feedback reports within short durations of each other

Those reports needed to be queued nicely and each report should be sent
with its correct respective system information not the one of the previous
report.

BUG= 593452 
Test=manually

Review URL: https://codereview.chromium.org/1794513002

Cr-Commit-Position: refs/heads/master@{#381768}

[modify] https://crrev.com/9c678f28bc8b50041b8aaa700714c75cd02b19f4/chrome/browser/extensions/api/feedback_private/feedback_service.cc
[modify] https://crrev.com/9c678f28bc8b50041b8aaa700714c75cd02b19f4/chrome/browser/extensions/api/feedback_private/feedback_service.h
[modify] https://crrev.com/9c678f28bc8b50041b8aaa700714c75cd02b19f4/chrome/browser/resources/feedback/js/event_handler.js
[modify] https://crrev.com/9c678f28bc8b50041b8aaa700714c75cd02b19f4/chrome/browser/resources/feedback/js/feedback.js

Status: Fixed (was: Started)
Labels: VerifyIn-51
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment