New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593436 link

Starred by 4 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
bettes@chromium.org
█ shrike@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 589941


Sign in to add a comment

[MaterialDesign] [Mac] Outlines have different colors

Project Member Reported by meh...@chromium.org, Mar 9 2016 
Version: Version 51.0.2672.0 canary (64-bit)
OS: OS X 10.11.3

What steps will reproduce the problem?
(1) Enable MD
(2) Take look at all outlines (Tabs, Toolbar top/bottom, NewTabButton)

What is the expected output? What do you see instead?
They all have different colors. Especially the Toolbar bottom outline is very dark when the Bookmarks bar is hidden. It should have the same color like the bottom outline of the Bookmarks bar to match the top and bottom outlines of the Omnibox dropdown.

Please use labels and text to provide additional information.

Screenshots are attached.

Thanks and regards
Mehmet
Bildschirmfoto 2016-03-09 um 21.09.04.png
54.3 KB View Download
Bildschirmfoto 2016-03-09 um 21.11.14.png
61.0 KB View Download

Comment 1 by shrike@chromium.org, Mar 9 2016

Blockedon: 589941
Labels: M-51
Hello Mehmet,

I should have mentioned that not all MD changes have landed. They are coming in pieces. So far it's been the tab strip and the toolbar (but not the lock icon, etc. that appear in the location bar). The plan is to finish the location bar, and then work on the bookmarks bar - fixing the color of this line will be part of that change. That is  bug 589941 . I will leave this issue open (and blocked on 589941) until I land that change.

Comment 2 by shrike@chromium.org, Mar 9 2016

Cc: bettes@chromium.org shrike@chromium.org sgabr...@chromium.org
 Issue 593507  has been merged into this issue.

Comment 3 by shrike@chromium.org, Mar 22 2016

Components: UI>Browser>Core

Comment 4 by shrike@chromium.org, May 6 2016

Labels: -M-51 M-52
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95661b05d996a9b77ae2738f71533be79e3c888d

commit 95661b05d996a9b77ae2738f71533be79e3c888d
Author: shrike <shrike@chromium.org>
Date: Thu May 19 22:10:43 2016

[Mac][Material Design] Update toolbar bottom border color.

This cl updates the border color at the bottom of the toolbar (when the
bookmarks bar is in NTP mode) and other locations to the correct value
for Material Design.

R=avi@chromium.org
BUG= 593436 

Review-Url: https://codereview.chromium.org/1950703002
Cr-Commit-Position: refs/heads/master@{#394885}

[modify] https://crrev.com/95661b05d996a9b77ae2738f71533be79e3c888d/chrome/browser/ui/cocoa/background_gradient_view.mm
[modify] https://crrev.com/95661b05d996a9b77ae2738f71533be79e3c888d/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.mm
[modify] https://crrev.com/95661b05d996a9b77ae2738f71533be79e3c888d/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm
[modify] https://crrev.com/95661b05d996a9b77ae2738f71533be79e3c888d/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm

Comment 6 by shrike@chromium.org, May 19 2016

Status: Fixed (was: Assigned)

Comment 7 by shrike@chromium.org, May 19 2016 

 Issue 594289  has been merged into this issue.
►

Sign in to add a comment