The perf_dashboard recipe module should use buildername rather than slave name. |
|||
Issue descriptionAt: https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/perf_dashboard/api.py&l=49 When building the dashboard link, it uses slavename: params = urllib.urlencode({ 'masters': self.m.properties['mastername'], 'bots': bot or self.m.properties['slavename'], 'tests': test, 'rev': revision, }) Instead it should use buildername. I think this is the case for get_skeleton_point as well.
,
Mar 10 2016
Issue 593428 has been merged into this issue.
,
Mar 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e commit e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e Author: qyearsley@chromium.org <qyearsley@chromium.org> Date: Thu Mar 10 23:19:06 2016 Use buildername rather than slavename for "bot" with perf dashboard. Rationale: This is what is used most commonly for the "bot" names on the perf dashboard, and the builder name usually gives a clearer idea of the platform (rather than the slave name, which often doesn't tell you the platform and can change if buildslaves are changed). The libvpx/android_unittest recipe uses the perf_dashboard recipe module; this CL changes that recipe to explicitly pass the slave name since that is what it has done in the past. Note that the expectations don't change for that recipe. BUG= 593431 Review URL: https://codereview.chromium.org/1782723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299231 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/api.py [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/example.expected/linux.json [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/example.expected/linux_use_mirror.json [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/example.expected/mac.json [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/example.expected/mac_use_mirror.json [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/example.expected/win.json [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipe_modules/perf_dashboard/example.expected/win_use_mirror.json [modify] https://crrev.com/e0ebbcfa62fd0f285b8ab0b18b3f931d50d3ef5e/scripts/slave/recipes/libvpx/android_unittests.py
,
Mar 10 2016
,
Mar 22 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=85091 ------------------------------------------------------------------ r85091 | recipe-roller@chromium.org | 2016-03-11T02:11:12.769917Z -----------------------------------------------------------------
,
Feb 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by leilei@chromium.org
, Mar 9 2016