New issue
Advanced search Search tips

Issue 593425 link

Starred by 1 user
Status: Fixed
Owner:
ekaramad@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

[Refactor] GetRenderWidgetHost() from All RenderWidgetHostView* into RenderWidgetHostViewBase.

Project Member Reported by ekaramad@chromium.org, Mar 9 2016 
Currently, there is similar implementations of the method RenderWidgetHostView::GetRenderWidgetHost() in all the RWHV*. They should all be inside RenderWidgetHostViewBase.

Comment 1 by ekaramad@chromium.org, Apr 5 2016

Summary: [Refactor] GetRenderWidgetHost() from All RenderWidgetHostView* into RenderWidgetHostViewBase. (was: Refactor GetRenderWidgetHost() from All RenderWidgetHostView* into RenderWidgetHostViewBase.)

Comment 2 by ekaramad@chromium.org, Apr 5 2016

Cc: -lfg@chromium.org
Wrong cc.

Comment 3 by ekaramad@chromium.org, Aug 22 2016

Status: Fixed (was: Untriaged)
This CL implements the method in the base class but does not refactor.
https://codereview.chromium.org/2240553003/

I think now we are safe with all the pure virtual call issues. But it would have been great if we could also remove the overrides from base classes.
►

Sign in to add a comment