Exiting fullscreen video breaks UI
Reported by
brandonv...@gmail.com,
Mar 9 2016
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36 Steps to reproduce the problem: 1. Visit YouTube 2. Play any video 3. Click on fullscreen 4. Hit ESC 5. See broken UI What is the expected behavior? What went wrong? See screencast movie: http://cloud.brandonthompson.net/3E0f0k191d3Q Did this work before? N/A Chrome version: 49.0.2623.87 Channel: stable OS Version: OS X 10.11.3 Flash Version: Shockwave Flash 20.0 r0
,
Mar 9 2016
,
Mar 14 2016
@brandonvault: Thanks for the report. I am unable to reproduce the above issue on Mac 10.11.3 with chrome version '49.0.2623.87' with the steps provided by you. I would request you to please try the above issue by creating a new user from chrome://settings and let us know if the issue still persists. Attach is the screen-cast for the same. Thank you!
,
Mar 14 2016
@ashjole: I created a new user, and the bug still exists using the new user profile.
,
Mar 14 2016
Just to confirm, this is video only, right? Is the normal fullscreen okay?
,
Mar 14 2016
Oh snap... It is an issue with fullscreen on any page. New screencast: http://cloud.brandonthompson.net/2K0Q3G1n0j2W Notice the spinning ball, and lag. Sorry, I should have tested that, but I don't usually use fullscreen for anything other than videos. Any ideas?
,
Mar 14 2016
No worries, recently we switched into using the OSX's system fullscreen so it looks like the system fullscreen is having issues. The spinning ball and lag is unusual...the delay might be the causing the layout issue at the normal fullscreen. I'll have to try some things out to be sure. Can you check to see if the fullscreen in other applications have a similar behavior? Thanks!
,
Mar 14 2016
Safari's fullscreen works without any issues.
,
Mar 14 2016
Great, thanks! I'll investigate this issue.
,
Mar 14 2016
Thank you for providing more feedback. Assigning to requester "ashejole@chromium.org" for another review. For more details visit https://sites.google.com/a/chromium.org/dev/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2016
Assigning back to spqchan@
,
Mar 16 2016
,
Mar 16 2016
I'm able to replicate the browser (not video) fullscreen issue by deliberately slowing down the fullscreen transition, which triggers a race condition. I'm unable to replicate the tabs cutoff issue, but I think I have an idea why that might be happening. A quick question in regards to the cutoff, does the UI fixes itself if you open a new tab?
,
Mar 16 2016
OK, good news and bad news. Bads news: No when you open a new tab, the new tab was cut off as well. Good news: The issues fixed itself, perhaps as a result of a system reboot.
,
Mar 24 2016
Issue 597502 has been merged into this issue.
,
Mar 24 2016
Issue 597501 has been merged into this issue.
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38ac6be27a783853f6a8fec136d2f4d3235a34d6 commit 38ac6be27a783853f6a8fec136d2f4d3235a34d6 Author: spqchan <spqchan@chromium.org> Date: Fri Mar 25 22:12:53 2016 Fixed a fullscreen race condition on OSX Ensure that |windowDidExitFullscreen| gets called after the fullscreen transition is completed. Slightly speed up the animations on Yosemite. BUG= 593419 Review URL: https://codereview.chromium.org/1813693003 Cr-Commit-Position: refs/heads/master@{#383381} [modify] https://crrev.com/38ac6be27a783853f6a8fec136d2f4d3235a34d6/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/38ac6be27a783853f6a8fec136d2f4d3235a34d6/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/38ac6be27a783853f6a8fec136d2f4d3235a34d6/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/38ac6be27a783853f6a8fec136d2f4d3235a34d6/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h [modify] https://crrev.com/38ac6be27a783853f6a8fec136d2f4d3235a34d6/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm
,
Apr 11 2016
Requesting merge for the submitted CL along with https://codereview.chromium.org/1850313002 (which fixes a dealloc issue introduced from this CL)
,
Apr 11 2016
[Automated comment] Less than 2 weeks to go before stable on M50, manual review required.
,
Apr 11 2016
Merge approved for M50 (branch 2661). Pls go ahead merge.
,
Apr 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/537895984fa99ea4939e7f810581d7f19c18c7a1 commit 537895984fa99ea4939e7f810581d7f19c18c7a1 Author: spqchan <spqchan@chromium.org> Date: Mon Apr 11 22:51:07 2016 Fixed a fullscreen race condition on OSX Ensure that |windowDidExitFullscreen| gets called after the fullscreen transition is completed. Slightly speed up the animations on Yosemite. BUG= 593419 Review URL: https://codereview.chromium.org/1813693003 Cr-Commit-Position: refs/heads/master@{#383381} (cherry picked from commit 38ac6be27a783853f6a8fec136d2f4d3235a34d6) Review URL: https://codereview.chromium.org/1876313002 . Cr-Commit-Position: refs/branch-heads/2661@{#556} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/537895984fa99ea4939e7f810581d7f19c18c7a1/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/537895984fa99ea4939e7f810581d7f19c18c7a1/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/537895984fa99ea4939e7f810581d7f19c18c7a1/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/537895984fa99ea4939e7f810581d7f19c18c7a1/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h [modify] https://crrev.com/537895984fa99ea4939e7f810581d7f19c18c7a1/chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm
,
Apr 13 2016
Tested the issue on Mac 10.11.3 using chrome version 50.0.2661.75 and reported version 49.0.2623.87 with the steps below 1. Go to any youtube video 2.Enter full screen and exit 3.Tried the same on new tab as well But unable to find the exact issue.Please find the attached screen cast and confirm anything missed here spqchan @ Please suggest to verify the fix from test team end. Thanks,
,
Apr 13 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by meh...@chromium.org
, Mar 9 2016Components: -UI UI>Browser>FullScreen