I still have an icon. But we seem to have lost our chrome.VisualElementsManifest.xml and/or VisualElementsManifest.xml which I think is what does that.

The one in win8/metro_driver/resources is only for dev builds I think, and the installer is supposed to generate the one for real installs (iirc?)

@Scott: right installer is supposed to generate chrome.VisualElementsManifest.xml for installed builds. I can confirm on my Win8.1 machine right now that this file is missing from Canary's Application dir though.. The icon still works on Win8.1's start page though (problem originally reported from my Win10 desktop).

Was unable to replicate this on Windows-10, latest canary(51.0.2673.0). The canary icon showed up in the Start menu of Windows-10. Attached is the screenshot for the same. 

Deleted: 593411_1.png 608 KB

	593411_1.png 608 KB View Download

I think something about r359345 broke the manifest. kVisualElementsManifest is not present in |src_path| as described here:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/setup/install_worker.cc&q=kVisualElementsManifest%20file:install_worker%5C.cc&sq=package:chromium&type=cs&l=343

So CreateVisualElementsManifest bails out due to the condition here:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/setup/install.cc&q=%22may%20not%20include%20visual%22%20file:install%5C.cc&sq=package:chromium&type=cs&l=319

Has this really been broken since M48 and we're just now noticing, or did something else change recently?

The VisualElements dir should be there still right? https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/mini_installer/chrome.release&l=73 But it isn't.

I guess errors are non fatal in that file?

Ugh, maybe because it's relying on metro_driver getting built, which it probably isn't any more (maybe. probably). https://code.google.com/p/chromium/codesearch#chromium/src/win8/metro_driver/metro_driver.gyp&q=logo.png%20file:gyp&sq=package:chromium&type=cs&l=110

Is that how Logo.png is supposed to get to the output dir?

Looks like, and metro_driver isn't even valid gyp ninja target any more. (Still my fault, but, at least it's more recently.)

The conflation of Ash/Metro with Win8 in various places is unfortunate.

I think you nailed it: looks metro_driver used to copy the images into the output dir. So r370263 is likely the regression, meaning M50. We'll need to merge a fix. I've verified that 50.0.2661.26 is missing VisualElements, while 49.0.2623.87 has it.

Based on offline chat with Scott removing the needs-bisect label, Since we already know the CL based on comment#10.

In the fix, please add an entry to each of the chrome/test/mini_installer/config/chrome_*_installed.prop files for the manifest so that test_installer.py will catch future regressions. Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/170c14bac8a2dc89c34907545116fb0a64e4f351

commit 170c14bac8a2dc89c34907545116fb0a64e4f351
Author: scottmg <scottmg@chromium.org>
Date: Sun Mar 13 00:15:16 2016

Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG= 593411 

Review URL: https://codereview.chromium.org/1790723002

Cr-Commit-Position: refs/heads/master@{#380886}

[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/chrome/BUILD.gn
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/chrome/chrome_exe.gypi
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/BUILD.gn
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/metro_driver/BUILD.gn
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/metro_driver/metro_driver.gyp
[rename] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/resources/Logo.png
[rename] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/resources/SecondaryTile.png
[rename] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/resources/SmallLogo.png
[rename] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/resources/chrome.VisualElementsManifest.xml
[modify] https://crrev.com/170c14bac8a2dc89c34907545116fb0a64e4f351/win8/win8.gyp

Your change meets the bar and is auto-approved for M50 (branch: 2661)

Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're very close to M50 Beta candidate cut. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4182a36f472e4db7d6e52fb999ff6500de079bba

commit 4182a36f472e4db7d6e52fb999ff6500de079bba
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Mar 14 16:42:42 2016

Fix missing VisualElementsManifest.xml

Move out of metro_driver too, as it doesn't have anything to do with
Metro in its current incarnation.

TBR=brettw@chromium.org
R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org
BUG= 593411 

Review URL: https://codereview.chromium.org/1790723002

Cr-Commit-Position: refs/heads/master@{#380886}
(cherry picked from commit 170c14bac8a2dc89c34907545116fb0a64e4f351)

Review URL: https://codereview.chromium.org/1801553004 .

Cr-Commit-Position: refs/branch-heads/2661@{#213}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/chrome/BUILD.gn
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/chrome/chrome_exe.gypi
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/chrome/test/mini_installer/config/chrome_canary_installed.prop
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/chrome/test/mini_installer/config/chrome_system_installed.prop
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/chrome/test/mini_installer/config/chrome_user_installed.prop
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/BUILD.gn
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/metro_driver/BUILD.gn
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/metro_driver/metro_driver.gyp
[rename] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/resources/Logo.png
[rename] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/resources/SecondaryTile.png
[rename] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/resources/SmallLogo.png
[rename] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/resources/chrome.VisualElementsManifest.xml
[modify] https://crrev.com/4182a36f472e4db7d6e52fb999ff6500de079bba/win8/win8.gyp

We should QA to manually verify this one.

And perhaps also QA what worked and what didn't without the fix as #4 said "no repro" yet this was a clear bug.

(trying to understand what the manifest actually does and doesn't do...)

PS: I confirm that my tile is back, except it's Google Chrome themed for a Canary install (see SS).

I forget if we'd ever hooked up Canary assets for Win8 -- I seem to recall we had..? Something like issue 517654 may be of useful reference?

Deleted: canary_tile_is_chrome.png 8.6 KB

	canary_tile_is_chrome.png 8.6 KB View Download

Props to prudhvi who pointed me @  issue 333743  which is the old "canary tile is Google Chrome themed on Win8" bug.

It was marked as WontFix as back in Win8 VisualElements only kicked in when it was default browser and making Canary default is considered an unsupported edge case.

In Win10 though it seems that default or not, my Canary tile is Google Chrome themed.. (maybe because of Windows caching some things though..? haven't tried rebooting..).

All that to say, I re-iterate that it would be nice to get a list of what happens both with and without the fix in various scenarios to understand the full effects of the manifest.

Is this something QA can make happen?

Thanks!

Rechecked this on chrome version 50.0.2661.37 on Windows 10 and fix is working as intended. Able to see Canary and chrome icons on Start menu. Attached screen shot for the same.

Also navigated to path "C:\Users\<username>\AppData\Local\Google\Chrome\Application" and was able to see "chrome.VisualElementsManifest.xml" file in the directory.

Please do let us know if any thing else needs to be verified here. 

Note: Fore reported 50.0.2657.0 version "chrome.VisualElementsManifest.xml" file is missing in the directory.

Adding TE-Verified labels.

Deleted: Icons.png 21.8 KB

	Icons.png 21.8 KB View Download

See my previous comment: we'd like to understand exactly which scenarios were broken before not just that it works now. Thanks!

Prudhvi, Can you please work with Greg to identify the scenarios that were broken before.