New issue
Advanced search Search tips

Issue 593406 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

we should track V8 startup performance of the individual TodoMVC examples and drive it down

Project Member Reported by jochen@chromium.org, Mar 9 2016

Issue description

While speedometer cycles through several of the todomvc examples, I think it's worthwhile to track the startup performance of each benchmark individually and drive the v8 related parts of the page load time down.

Tracking those individually should also make it easier to catch possible regressions in the future.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05b8991eb423b2deba6283856277846b3ef0981

commit b05b8991eb423b2deba6283856277846b3ef0981
Author: jochen <jochen@chromium.org>
Date: Wed Mar 09 21:19:23 2016

[telemetry] Add TodoMVC examples based test for V8 to telemetry

BUG= 593406 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1781603002

Cr-Commit-Position: refs/heads/master@{#380221}

[modify] https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981/tools/perf/benchmarks/v8.py
[add] https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981/tools/perf/page_sets/data/todomvc.json
[add] https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981/tools/perf/page_sets/data/todomvc_000.wpr.sha1
[add] https://crrev.com/b05b8991eb423b2deba6283856277846b3ef0981/tools/perf/page_sets/todomvc.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3ab2038968911557fdac7b782732c766f5f099

commit 7c3ab2038968911557fdac7b782732c766f5f099
Author: jochen <jochen@chromium.org>
Date: Fri Mar 11 14:47:46 2016

[telemetry] Add page load interaction to V8.todomvc

The timeline based measurement requires an interaction to output
anything.

BUG= 593406 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
R=cbruni@chromium.org,ulan@chromium.org,eakuefner@chromium.org,skyostil@chromium.org

Review URL: https://codereview.chromium.org/1782033002

Cr-Commit-Position: refs/heads/master@{#380629}

[modify] https://crrev.com/7c3ab2038968911557fdac7b782732c766f5f099/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/7c3ab2038968911557fdac7b782732c766f5f099/tools/perf/page_sets/todomvc.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ad53088c557f997dbb969e30902bbd5ffe5dd7

commit 52ad53088c557f997dbb969e30902bbd5ffe5dd7
Author: jochen <jochen@chromium.org>
Date: Thu Mar 17 15:35:59 2016

[telemetry] Add a version of v8.todomvc that runs using ignition

R=rmcilroy@chromium.org,cbruni@chromium.org,danno@chromium.org,skyostil@chromium.org
BUG= chromium:593406 , v8:4280 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1802273002

Cr-Commit-Position: refs/heads/master@{#381716}

[modify] https://crrev.com/52ad53088c557f997dbb969e30902bbd5ffe5dd7/tools/perf/benchmarks/v8.py

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa9a399a5044478446cf442494414ce7927658c

commit caa9a399a5044478446cf442494414ce7927658c
Author: jochen <jochen@chromium.org>
Date: Mon Mar 21 15:29:12 2016

[telemetry] Don't include "" in the --js-flag args used in v8 benchmarks

The "" would only be required by a shell, adding them here actually
breaks parsing of those flags

R=ulan@chromium.org,cbruni@chromium.org,rmcilroy@chromium.org,skyostil@chromium.org
BUG= chromium:593406 , v8:4280 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1821633002

Cr-Commit-Position: refs/heads/master@{#382293}

[modify] https://crrev.com/caa9a399a5044478446cf442494414ce7927658c/tools/perf/benchmarks/v8.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5800dfe3f534cd97ff433501b3e45c56831d2f2b

commit 5800dfe3f534cd97ff433501b3e45c56831d2f2b
Author: jochen <jochen@chromium.org>
Date: Wed Apr 06 04:09:18 2016

Upgrade v8.todomvc{,-ignition} to TBMv2

BUG= 593406 , 593793 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1857613002

Cr-Commit-Position: refs/heads/master@{#385381}

[modify] https://crrev.com/5800dfe3f534cd97ff433501b3e45c56831d2f2b/tools/perf/benchmarks/v8.py

Comment 6 by jochen@chromium.org, Apr 22 2016

Status: Fixed (was: Assigned)

Sign in to add a comment