New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593390 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago

Project Member Reported by torne@chromium.org, Mar 9 2016

Issue description

Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago.


Add Bug number which got updated: issue 532416


Issue/Concern or feedback: I'd already responded telling them their feedback was not useful. Maybe the bot shouldn't re-label/assign things where the requester already responded?


Any other important details:

 

Comment 1 by gov...@chromium.org, Mar 10 2016

Cc: -lafo...@chromium.org gov...@chromium.org
Owner: lafo...@chromium.org
Anthony, what do you think on this rule?

Comment 2 by cda...@chromium.org, Mar 10 2016

I agree we should not assign when requester responded but again we cannot assume the that the requester left the "Needs-Feedback" label because they need more feedback.

So I'm thinking we should add a different message when this happens and close these bugs ( if it has not touched for certain days after our message.)

Please let me know if this works. Thanks

Comment 3 by gov...@chromium.org, Mar 10 2016

Related  bug 593824 

Comment 4 by gov...@chromium.org, Mar 10 2016

Cc: mbarbe...@chromium.org
I think that part of this is that we doing this retro-actively on a bunch of old bugs, so it's creating a lot of odd state that won't be present when the bot is continually checking for responses/ removes needs-feedback quickly.

Not sure if there are more of these legacy cases to process, but we might want to establish some initial threshold criteria for bootstrapping (e.g. [not relevant to this case, but provided as an example] if it's closed Needs-Feedback should be stripped).
Status: Fixed (was: Assigned)
Now we're continually checking for responses and removing needs-feedback label on daily basis. Also we  made changes to the rule as described in  issue 596470 . So marking this bug as fixed. Please reopen if needed. Thank you.

Comment 7 by torne@chromium.org, Apr 26 2016

Status: Untriaged (was: Fixed)
This still isn't quite working how I would expect - in cases where I add needs-feedback, the reporter responds, and then I respond asking for more feedback, the bot still removes the label and reassigns to me. See  issue 606677  for an example. The bot just isn't running frequently enough to be able to do the right thing here without more complex logic, I think?

This is the same issue as I originally reported here, but for a new bug, and not retroactively on old bugs.
Status: Fixed (was: Untriaged)
Flipping this back to fixed.

Sign in to add a comment