Chrome password sync should not serialize empty federation_url as "null" |
||||||
Issue descriptionVersion: 51.0.2673.0 (Developer Build) (64-bit) OS: all This is a follow-up to http://crbug.com/591310 (it wasn't really fixed). Chrome should serialize an empty federation as "". Currently it uploads "null" breaking Android and passwords.google.com.
,
Mar 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1e26c7b4a6f7d692312f4de15996e33b1c10a90 commit c1e26c7b4a6f7d692312f4de15996e33b1c10a90 Author: vasilii <vasilii@chromium.org> Date: Wed Mar 09 18:55:50 2016 Don't upload "null" to the Sync server for empty federation_url. BUG= 593380 Review URL: https://codereview.chromium.org/1780683002 Cr-Commit-Position: refs/heads/master@{#380164} [modify] https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90/components/password_manager/core/browser/password_syncable_service.cc [modify] https://crrev.com/c1e26c7b4a6f7d692312f4de15996e33b1c10a90/components/password_manager/core/browser/password_syncable_service_unittest.cc
,
Mar 10 2016
I want to merge r380164 back. Without this patch Chrome pollutes the Sync password database with trash.
,
Mar 10 2016
,
Mar 10 2016
I also strongly support merging into M50. During PasswordSyncableService::MergeDataAndStartSyncing it will save all old passwords to the passwords database. While this isn't causing any incorrect behavior, this takes a significant amount of time and substantially delays sync's initialization as well.
,
Mar 10 2016
Issue 593124 has been merged into this issue.
,
Mar 10 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 10 2016
Issue 593124 has been merged into this issue.
,
Mar 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daaf129eb29d09495b47506e75f0ffce217b5979 commit daaf129eb29d09495b47506e75f0ffce217b5979 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Mar 10 18:27:19 2016 Don't upload "null" to the Sync server for empty federation_url. BUG= 593380 Review URL: https://codereview.chromium.org/1780683002 Cr-Commit-Position: refs/heads/master@{#380164} (cherry picked from commit c1e26c7b4a6f7d692312f4de15996e33b1c10a90) Review URL: https://codereview.chromium.org/1778423002 . Cr-Commit-Position: refs/branch-heads/2661@{#177} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/daaf129eb29d09495b47506e75f0ffce217b5979/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/daaf129eb29d09495b47506e75f0ffce217b5979/components/password_manager/core/browser/password_syncable_service.cc [modify] https://crrev.com/daaf129eb29d09495b47506e75f0ffce217b5979/components/password_manager/core/browser/password_syncable_service_unittest.cc
,
Mar 10 2016
,
Mar 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac73e63122b49923dfdd76fa4de06529456a9c77 commit ac73e63122b49923dfdd76fa4de06529456a9c77 Author: vasilii <vasilii@chromium.org> Date: Tue Mar 22 09:13:08 2016 Add unit test for correct serialization of autofill::PasswordForm to PasswordSpecifics. BUG= 593380 Review URL: https://codereview.chromium.org/1786153002 Cr-Commit-Position: refs/heads/master@{#382537} [modify] https://crrev.com/ac73e63122b49923dfdd76fa4de06529456a9c77/components/password_manager/core/browser/password_syncable_service_unittest.cc
,
May 31 2016
Issue 595318 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vasi...@chromium.org
, Mar 9 2016Components: UI>Browser>Passwords