New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593379 link

Starred by 3 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
bettes@chromium.org
█ shrike@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

Different text coloring for http v. https (native MD)

Project Member Reported by pinkerton@chromium.org, Mar 9 2016 
Version: M51 canary
OS: 10.11.3

- enable MD in chrome://flags

For https sites, the domain is in black and the rest of the url is light gray. For http, the entire url is light gray. 

Not sure why they're different.

Comment 1 by shrike@chromium.org, Mar 9 2016

Blocking: 547953
Status: Started (was: Assigned)
The cause is some errant code I introduced in the OmniboxViewMac changes.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0b22c0cb636e508e54e88204eba1ec1e084a60

commit 5a0b22c0cb636e508e54e88204eba1ec1e084a60
Author: shrike <shrike@chromium.org>
Date: Wed Mar 09 20:06:43 2016

Fix bug with http URL color in location bar (Mac).

This is a fix for a regression introduced in the recent Material Design
toolbar changes.

BUG= 593379 

Review URL: https://codereview.chromium.org/1781753002

Cr-Commit-Position: refs/heads/master@{#380188}

[modify] https://crrev.com/5a0b22c0cb636e508e54e88204eba1ec1e084a60/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Comment 3 by shrike@chromium.org, Mar 9 2016

Status: Fixed (was: Started)

Comment 4 by shrike@chromium.org, Mar 11 2016

Cc: bettes@chromium.org shrike@chromium.org
 Issue 593372  has been merged into this issue.
►

Sign in to add a comment