New issue
Advanced search Search tips

Issue 593377 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Unmocked Placeholders should return unambiguous data

Project Member Reported by iannucci@chromium.org, Mar 9 2016

Issue description

A common problem when writing recipes is that many steps output JSON data, but when the test didn't supply it, the returned data defaults to some possibly-fine value like None. This data ends up percolating down the recipe until it ends up breaking some other assumption later.

I think we can improve the experience by having unmocked Placeholders return a special Unmocked singleton, which will cause the recipe engine to raise an exception any time this value is accessed that includes a detailed breakdown of what happened, e.g. Step "somestep" uses an output Placeholder `json.output` which was not mocked in the test.
 

Comment 1 by aga...@chromium.org, Apr 26 2016

Components: Infra>Platform>Recipes
Labels: -Infra-Recipes
Labels: Pri-2
Labels: Type-Bug
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Status: Available (was: Untriaged)
Cc: -qyears...@chromium.org
Description: Show this description
Project Member

Comment 7 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: iannucci@chromium.org
+iannucci for Triage: Still needed?
Status: Available (was: Untriaged)
Status: Assigned (was: Available)
Owner: iannu...@google.com
Cc: iannu...@google.com

Sign in to add a comment