New issue
Advanced search Search tips

Issue 593375 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Mojo EventPtr to WebInputEvent conversion needs to pass PointerType

Project Member Reported by mustaq@chromium.org, Mar 9 2016

Issue description

blink_input_events_type_converters.cc doesn't currently set PointerType, hence the information available in low-level input events are lost at this point.

 
Status: Assigned (was: Unconfirmed)
Cc: sky@chromium.org
Status: Started (was: Assigned)
Hi Scott:

I have a local patch to fix this, all I need is to look at events Blink received in blink. How do I force low-level events pass thru blink_input_events_type_converters? Guess I need some build flag?

Mustaq

Comment 3 by sky@chromium.org, Mar 9 2016

If you want to actually run this build (gn only) mash:all and chrome and then to run do mojo_runner mojo:mash_shell .
If you only care about building then, again with gn, build mojo/converters/blink
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbf25032a5f5849240b3e17721a0a4edb0de9e81

commit bbf25032a5f5849240b3e17721a0a4edb0de9e81
Author: mustaq <mustaq@chromium.org>
Date: Wed Apr 13 21:29:32 2016

Pass PointerType from Mojo EventPtr to WebInputEvent.

BUG= 593375 

Review URL: https://codereview.chromium.org/1880673002

Cr-Commit-Position: refs/heads/master@{#387102}

[modify] https://crrev.com/bbf25032a5f5849240b3e17721a0a4edb0de9e81/mojo/converters/blink/blink_input_events_type_converters.cc

Comment 5 by mustaq@chromium.org, Apr 14 2016

Status: Fixed (was: Started)

Sign in to add a comment