New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 593371 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

Toolbar button hover highlight hard to see in Incognito Material Design (Mac)

Project Member Reported by shrike@chromium.org, Mar 9 2016

Issue description

Please see the attached screenshot.

 
Screen Shot 2016-03-09 at 9.07.22 AM.png
75.8 KB View Download
Bumped the opacity value to 12% for hover and 16% for pressed. This only applies for incognito. 

Preview attached. Full spec updated: https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEVzZma1BDT3ZuaUU/view?usp=sharing
hover.png
16.0 KB View Download
pressed.png
10.5 KB View Download
Cc: -shrike@chromium.org sgabr...@chromium.org
Owner: shrike@chromium.org

Comment 3 by shrike@chromium.org, Mar 22 2016

Components: UI>Browser>Core
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45e5facee3ebc508b5c7c59d9c9940d7eac53af3

commit 45e5facee3ebc508b5c7c59d9c9940d7eac53af3
Author: shrike <shrike@chromium.org>
Date: Wed Apr 06 22:30:47 2016

[Mac] Increase contrast of toolbar button hover bg in MD Incognito.

The toolbar button hover states are difficult to see in Material Design
Incognito mode. This change increases the contrast.

R=avi@chromium.org
BUG= 593371 

Review URL: https://codereview.chromium.org/1858393002

Cr-Commit-Position: refs/heads/master@{#385570}

[modify] https://crrev.com/45e5facee3ebc508b5c7c59d9c9940d7eac53af3/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm

Status: Fixed (was: Started)

Sign in to add a comment