Enable Mac save card bubble in M50 |
|||||
Issue descriptionThe following CLs are required to enable the bubble (as a replacement for the save card infobar). ---- commit 319c897905a59fbfc6a0bcc4dd91470df9ab5bb0 Author: jdonnelly <jdonnelly@chromium.org> Date: Mon Mar 07 21:55:58 2016 Add explanation text and legal message footer to upload bubble. BUG=566271 Review URL: https://codereview.chromium.org/1757103002 Cr-Commit-Position: refs/heads/master@{#379655} ---- commit dff48ce2ab293d4f1db86e6f15a6a06f7a01699e Author: jdonnelly <jdonnelly@chromium.org> Date: Mon Mar 07 20:18:06 2016 Call OnDecorationsChanged when the save card icon is updated. Failing to do so results in several bugs: - The save card icon sometimes fails to appear. - The cursor rect for the omnibox isn't updated, resulting in the wrong mouse icon being shown when hovering over the save card icon. - The save card icon tooltip doesn't appear. BUG=566271 Review URL: https://codereview.chromium.org/1760273002 Cr-Commit-Position: refs/heads/master@{#379629} ---- commit f41a2211a775b1f607eabe0c8e934daa42c15be0 Author: jdonnelly <jdonnelly@chromium.org> Date: Wed Mar 09 05:13:01 2016 Enable the save card bubble on Mac without a flag. BUG=566271 Review URL: https://codereview.chromium.org/1761073005 Cr-Commit-Position: refs/heads/master@{#380073}
,
Mar 10 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 10 2016
Meh, forgot to add the ID of this issue to those three CLs before I merged them. Here's the merge summaries: ---- The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/473abc61012fe0f7c76bf4e9a69c5b5e5671fe0a commit 473abc61012fe0f7c76bf4e9a69c5b5e5671fe0a Author: Justin Donnelly <jdonnelly@chromium.org> Date: Thu Mar 10 16:17:41 2016 Add explanation text and legal message footer to upload bubble. BUG= 566271 Review URL: https://codereview.chromium.org/1757103002 Cr-Commit-Position: refs/heads/master@{#379655} (cherry picked from commit 319c897905a59fbfc6a0bcc4dd91470df9ab5bb0) Review URL: https://codereview.chromium.org/1783833002 . Cr-Commit-Position: refs/branch-heads/2661@{#172} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/473abc61012fe0f7c76bf4e9a69c5b5e5671fe0a/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.h [modify] https://crrev.com/473abc61012fe0f7c76bf4e9a69c5b5e5671fe0a/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_bridge.mm [modify] https://crrev.com/473abc61012fe0f7c76bf4e9a69c5b5e5671fe0a/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_unittest.mm ---- The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/227cc13e10ee044a49b02c0a380315a8ab18b530 commit 227cc13e10ee044a49b02c0a380315a8ab18b530 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Thu Mar 10 16:22:28 2016 Call OnDecorationsChanged when the save card icon is updated. Failing to do so results in several bugs: - The save card icon sometimes fails to appear. - The cursor rect for the omnibox isn't updated, resulting in the wrong mouse icon being shown when hovering over the save card icon. - The save card icon tooltip doesn't appear. BUG= 566271 Review URL: https://codereview.chromium.org/1760273002 Cr-Commit-Position: refs/heads/master@{#379629} (cherry picked from commit dff48ce2ab293d4f1db86e6f15a6a06f7a01699e) Review URL: https://codereview.chromium.org/1783693003 . Cr-Commit-Position: refs/branch-heads/2661@{#173} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/227cc13e10ee044a49b02c0a380315a8ab18b530/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ---- The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f201b57ae6af9bc5694e6f8479c5639121311cca commit f201b57ae6af9bc5694e6f8479c5639121311cca Author: Justin Donnelly <jdonnelly@chromium.org> Date: Thu Mar 10 16:29:22 2016 Enable the save card bubble on Mac without a flag. BUG= 566271 Review URL: https://codereview.chromium.org/1761073005 Cr-Commit-Position: refs/heads/master@{#380073} (cherry picked from commit f41a2211a775b1f607eabe0c8e934daa42c15be0) Review URL: https://codereview.chromium.org/1779193002 . Cr-Commit-Position: refs/branch-heads/2661@{#174} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/f201b57ae6af9bc5694e6f8479c5639121311cca/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/f201b57ae6af9bc5694e6f8479c5639121311cca/components/autofill/core/common/autofill_switches.cc [modify] https://crrev.com/f201b57ae6af9bc5694e6f8479c5639121311cca/components/autofill/core/common/autofill_switches.h
,
Mar 10 2016
,
Mar 10 2016
I'll verify in the next Beta.
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by zkoch@chromium.org
, Mar 9 2016