New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 563832

Blocking:
issue 563816



Sign in to add a comment

Preserve context state in OffscreenCanvas.transferToImageBitmap

Project Member Reported by junov@chromium.org, Mar 9 2016 Back to list

Issue description

When calling OffscreenCanvas.transferToImageBitmap, the canvas's backing is transfered, but the full context state must be retained, including the matrix and clip stack on the ImageBufferSurface.

 

Comment 1 by junov@chromium.org, Mar 9 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b46b601d0286d9ffc010250ce48602f21bfd6404

commit b46b601d0286d9ffc010250ce48602f21bfd6404
Author: junov <junov@chromium.org>
Date: Fri May 27 21:08:50 2016

Fix 2D canvas state persistency after OffscreenCanvas.transferToImageBitmap

This change restores the matrix and clip state stack on the new
ImageBuffer that get created by OffscreenCanvasRenderingContext2D
after the previous buffer was torn off by transferToImageBItmap.
This change also adds the clip() method to OffscreenCanvasRenderingContext2D.

BUG= 593349 

Review-Url: https://codereview.chromium.org/1995733005
Cr-Commit-Position: refs/heads/master@{#396559}

[add] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferToImageBitmap-state-persistency-expected.txt
[add] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferToImageBitmap-state-persistency.html
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
[modify] https://crrev.com/b46b601d0286d9ffc010250ce48602f21bfd6404/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl

Comment 3 by junov@chromium.org, Jun 9 2016

Status: Fixed (was: Assigned)

Sign in to add a comment