New issue
Advanced search Search tips

Issue 593341 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Human readable origins for Android credentials on chrome://settings/passwords

Project Member Reported by kolos@chromium.org, Mar 9 2016

Issue description

Indroduce human readable origins for Android credentials on chrome://settings/passwords. Now Chrome shows something like "android://com.nytymes.account". 

It is better to converge Android credentials to regular form, e.g. "accounts.nytimes.com (Android)". Web realms affiliated with Android application should be requested via AffiliatedMatchHelper. 

 

Comment 1 by vabr@chromium.org, Mar 9 2016

Thanks for the bug. As in  bug 593027  it would be helpful to have some pointers to the design discussions here, in case questions come in the future.

Comment 2 by kolos@chromium.org, Mar 18 2016

android.jpg
42.0 KB View Download
android_rtl.jpg
39.8 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/983af5012da174a6a50c38ea956e2e1422646995

commit 983af5012da174a6a50c38ea956e2e1422646995
Author: kolos <kolos@chromium.org>
Date: Thu Mar 31 09:54:38 2016

[Password manager] Human readable origins for Android credentials on chrome://settings/passwords

PasswordStore::GetAutofillableLoginsWithAffiliatedRealms is introduced in this CL. It is same as GetAutofillableLogins, but also send a request to AffiliatedMatchHelper to fetch affiliated web realm and inject it into |form.affiliated_web_realm|. The request doesn't issue an on-demand network request. If a request to cache fails, no web realm will be injected into corresponding form.

If there are a number of affiliated web realms, an arbitrary realm is injected.

Origin for Android credentials will be shown like "example.com (Android)", where "example.com" is the fetched web realm.

BUG= 593341 

Review URL: https://codereview.chromium.org/1615653005

Cr-Commit-Position: refs/heads/master@{#384236}

[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/chrome/app/generated_resources.grd
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/chrome/browser/resources/options/password_manager.js
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/chrome/browser/resources/options/password_manager_list.js
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/chrome/browser/ui/webui/options/password_manager_handler.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/autofill/core/common/password_form.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/autofill/core/common/password_form.h
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/affiliated_match_helper.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/affiliated_match_helper.h
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/mock_affiliated_match_helper.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/mock_affiliated_match_helper.h
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/password_store.h
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/password_store_unittest.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/password_ui_utils.cc
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/password_ui_utils.h
[modify] https://crrev.com/983af5012da174a6a50c38ea956e2e1422646995/components/password_manager/core/browser/password_ui_utils_unittest.cc

Comment 5 by kolos@chromium.org, Mar 31 2016

Status: Fixed (was: Started)

Sign in to add a comment