New issue
Advanced search Search tips

Issue 593325 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Update password bubble disappears before any user action on Foxnews.com, during password change/reset.

Project Member Reported by ashej...@chromium.org, Mar 9 2016

Issue description

OS:ALL
Chrome version: 50.0.2661.22.

Valid username: amokqa@gmail.com
Password: amokqa1910

Steps to reproduce the above issue.

1. Navigate to foxnews.com
2. Login in with valid credentials.
3. Password bubble will be shown, click on save.
4. Navigate to profile and change the password.
5. Observe the update bubble.

Expected: Update password bubble should not disappear before any user action on Foxnews.com, during password change.

Actual:Update password bubble disappears before any user action on Foxnews.com, during password change.

@vadyms: Request you to please check the above issue ?

Attach below is the screen-cast for the same.

Thank you!
 
Update password bubble-9th march.ogv
3.7 MB Download
Summary: Update password bubble disappears before any user action on Foxnews.com, during password change/reset. (was: Update password bubble disappears before any user action on Foxnews.com, during password change.)

Comment 2 by vabr@chromium.org, Mar 10 2016

Owner: dvadym@chromium.org
Wrong Vadym, fixing.
Hey, Apologies my bad. Thanks for the update.

Comment 4 by dvadym@chromium.org, Mar 11 2016

Labels: -Restrict-View-Google -Pri-1 Pri-2
Thanks for report!

The reason of such behavior is that after a successful password change a new change password form appears on the page and Password Manager fills it and so manage bubble is shown. Probably the best solution is not to turn bubble in manage state, if it's currently in Save or Update state. I'll fix it.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f89c67271a18d8b6ae96a410e6999f2d61f3b26c

commit f89c67271a18d8b6ae96a410e6999f2d61f3b26c
Author: dvadym <dvadym@chromium.org>
Date: Thu Mar 24 13:33:47 2016

Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE, PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to MANAGED_STATE when autofill happens.

BUG= 593325 

Review URL: https://codereview.chromium.org/1826473002

Cr-Commit-Position: refs/heads/master@{#383058}

[modify] https://crrev.com/f89c67271a18d8b6ae96a410e6999f2d61f3b26c/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/f89c67271a18d8b6ae96a410e6999f2d61f3b26c/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/f89c67271a18d8b6ae96a410e6999f2d61f3b26c/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc

Comment 6 by dvadym@chromium.org, Apr 13 2016

Status: Fixed (was: Assigned)

Sign in to add a comment