New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593302 link

Starred by 3 users
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Extension hidden in chrome menu vanishes from wrench after extension pop-up opened.

Reported by jshan...@etouch.net, Mar 9 2016 
Chrome Version: 51.0.2672.0 (Official Build) b4fd57023ade2863e463d3380456968dca6c8bcf-refs/heads/master@{#380022}-32/64 bit
OS: Windows(Win 7-Aero Enabled), Mac

Precondition: Enable 'Extension toolbar redesign' from chrome://flags

URL: https://chrome.google.com/webstore/detail/cats/pdfklfdfahcjkkkogigggbfhbojcnhgb?hl=en

Steps: 
1. Launch Chrome and add above extension
2. Right click on extension icon beside ominibox and select 'Hide in Chrome menu' option from context menu.
3. Now click on hidden extension from wrench menu (Extension pop up opens) and then click on Wrench menu
4. Observe inside wrench menu.

Actual: Hidden extension does not appear in Wrench menu after step 3

Expected:  Hidden extension should appear in Wrench menu after step 3

This is regression issue,broken in 'M 47' and below is bisect info

Good build: 47.0.2511.0
Bad build: 47.0.2512.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/4dc350fb506b83d5ff62c0be8ac9a45ca20a1616..4f0e1427488d5101c877f232258320c8d8e0c41f?pretty=fuller&n=100

Suspecting: r349504 ?

Note: Above issue is not reproducible Linux OS.
Actual_Result.mp4
660 KB Download
Expected_Result.mp4
385 KB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7be157366869c9aac12317e705cd2cbc757bac9a

commit 7be157366869c9aac12317e705cd2cbc757bac9a
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Fri Mar 11 18:52:22 2016

[Extensions UI] Update ToolbarActionsBar::NeedsOverflow() for popped out actions

Update the logic in the ToolbarActionsBar to account for popped out actions when
determining if an overflow menu is necessary.

BUG= 593302 
TBR=avi@chromium.org (trivial cocoa change)

Review URL: https://codereview.chromium.org/1782223002

Cr-Commit-Position: refs/heads/master@{#380686}

[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/cocoa/extensions/browser_action_button.mm
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/extensions/extension_action_view_controller.cc
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/toolbar/toolbar_actions_bar.h
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
[modify] https://crrev.com/7be157366869c9aac12317e705cd2cbc757bac9a/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h

Comment 2 by jshan...@etouch.net, Mar 14 2016

Labels: -hasTestcase hasbisect

Comment 3 by rdevlin....@chromium.org, Oct 21 2016

Status: Fixed (was: Assigned)
I think this was fixed by #1
►

Sign in to add a comment