New issue
Advanced search Search tips

Issue 593288 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 760579
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 774955



Sign in to add a comment

Changed password doesn't get updated even after sign off and re-sign in.

Project Member Reported by ajha@chromium.org, Mar 9 2016

Issue description

Version: 50.0.2661.22
OS: All

What steps will reproduce the problem?
(1) Launch chrome and go to weather.com.
(2) Sign in using test account and save the credentials when prompted.
(3) Change the password of the site and sign-out.
(4) The old saved credentials is autofilled and trying to sign in gives the error message to sign in with valid credentials.
(5) Now, sign in using the changed credential and observe.

What is the expected output? 
> Signning in using changed credential should prompt the user to save the new password or update the already saved password.

What do you see instead?
> The old saved credential is autofilled and doesn't prompt the user to save the new password even after multiple sign out and re-sign.

Please use labels and text to provide additional information.
> Attached is the screen-cast of the behavior.

dvadym@: Could you please take a look at this.



 
NewPasswordNotUpdated.mp4
4.6 MB Download

Comment 1 by kolos@chromium.org, Jan 26 2018

Blocking: 774955

Comment 2 by kolos@chromium.org, Jan 29 2018

still doesn't work LocalFrameClientImpl::DispatchWillSubmitForm isn't triggered. 
Mergedinto: 760579
Owner: battre@chromium.org
Status: Duplicate (was: Assigned)
This seems to be fixed with the patch landed for 760579. Please reopen if you still experience the problem on canary channel.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67

commit fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67
Author: Dominic Battre <battre@chromium.org>
Date: Fri Feb 09 11:00:25 2018

More robust capturing <form>s that are taken out of the DOM.

Chrome's password manager tries to capture events where <form> elements
are taken out of the DOM or made invisible. This is used to detect
form submissions. This trigger failed in the past if a parent element
for the form was removed from the DOM or made invisible (as opposed
to the form it self). This CL makes the trigger logic more robust.

Bug:  760579 ,  710431 ,  593288 , 808911
Change-Id: I3dbe4618a8811da3299a1884bc37db3d46a79adb
Reviewed-on: https://chromium-review.googlesource.com/910968
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535682}
[modify] https://crrev.com/fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.cpp

Sign in to add a comment