New issue
Advanced search Search tips

Issue 593269 link

Starred by 2 users
Status: Fixed
Owner:
haraken@chromium.org
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 592880



Sign in to add a comment

Clean up Blink's initialization/shutdown logic

Project Member Reported by haraken@chromium.org, Mar 9 2016 
Initialization and shutdown should be unified into:

- blink::initialize/shutdown (for wtf, platform, core, modules and web)
- Platform::initialize/shutdown (for wtf and platform)

XXX::initialize and XXX::shutdown must be implemented in a symmetric manner (i.e., things must be shut down in the reversed order of initialization). initialize/shutdownWithoutV8 should be gone.

Comment 1 by sigbjo...@opera.com, Mar 9 2016

Blocking: 582755

Comment 2 by sigbjo...@opera.com, Mar 9 2016

Blocking: -582755 592880
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2628e5ca3e670725639f6e8def4287c276513f6a

commit 2628e5ca3e670725639f6e8def4287c276513f6a
Author: haraken <haraken@chromium.org>
Date: Wed Mar 09 14:07:23 2016

Move code to register Oilpan's interruptor to V8Initializer::initialize

The code is about V8, so it should be in V8Initializer::initialize.

BUG= 593269 

Review URL: https://codereview.chromium.org/1779733002

Cr-Commit-Position: refs/heads/master@{#380133}

[modify] https://crrev.com/2628e5ca3e670725639f6e8def4287c276513f6a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/2628e5ca3e670725639f6e8def4287c276513f6a/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46eaaf1c1504445b80015794296b2ca2dcb9dcb1

commit 46eaaf1c1504445b80015794296b2ca2dcb9dcb1
Author: haraken <haraken@chromium.org>
Date: Thu Mar 10 01:43:24 2016

Change the order of Platform::initialize and WTF::initialize

Previously there was a strange dependency between platform and wtf
(around setCurrentTimeFunction) and we couldn't initialize wtf before platform.
Now the dependency is gone (https://codereview.chromium.org/1550563002/).
We can initialize in the order of wtf => platform, and shutdown in the order of
platform => wtf.

BUG= 593269 

Review URL: https://codereview.chromium.org/1778773003

Cr-Commit-Position: refs/heads/master@{#380295}

[modify] https://crrev.com/46eaaf1c1504445b80015794296b2ca2dcb9dcb1/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce367ff2ad0cd2d99ded533b1260028fa57e6554

commit ce367ff2ad0cd2d99ded533b1260028fa57e6554
Author: haraken <haraken@chromium.org>
Date: Thu Mar 10 02:20:35 2016

Move ScriptStreamerThread::shutdown to CoreInitializer::shutdown

ScriptStreamerThread::initialize is called in CoreInitializer::initialize.
Thus ScriptStreamerThread::shutdown should be called in CoreInitializer::shutdown.

BUG= 593269 

Review URL: https://codereview.chromium.org/1776183004

Cr-Commit-Position: refs/heads/master@{#380309}

[modify] https://crrev.com/ce367ff2ad0cd2d99ded533b1260028fa57e6554/third_party/WebKit/Source/core/Init.cpp
[modify] https://crrev.com/ce367ff2ad0cd2d99ded533b1260028fa57e6554/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ec0cea30571de24eb8cc243c867ed346a9205ad

commit 1ec0cea30571de24eb8cc243c867ed346a9205ad
Author: haraken <haraken@chromium.org>
Date: Thu Mar 10 07:26:46 2016

Introduce Platform::setCurrentPlatformForTesting

In preparation for cleaning up the initialization/shutdown logic of Blink,
I need to make Platfrom::initialize() and Platform::shutdown() are balanced
(i.e., Platfrom::initialize() and Platform::shutdown() should be called only once
respectively.)

Currently TestingPlatformSupport violates the contract (i.e., it calls Platfrom::initialize()
multiple times). This CL introduces Platform::setCurrentPlatformForTesting
and makes sure that Platfrom::initialize() is called only once.

BUG= 593269 

Review URL: https://codereview.chromium.org/1780083002

Cr-Commit-Position: refs/heads/master@{#380370}

[modify] https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad/third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
[modify] https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad/third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp
[modify] https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify] https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad/third_party/WebKit/public/platform/Platform.h
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f80d2873f5d74c33b908be46dd57ba01d5af6c36

commit f80d2873f5d74c33b908be46dd57ba01d5af6c36
Author: haraken <haraken@chromium.org>
Date: Thu Mar 10 12:47:39 2016

Make sure that s_platform is non-null

Currently s_platform can be null in platform_unittests.
This CL introduces DummyPlatform and makes sure that s_platform is non-null
(except after Platform::shutdown).

BUG= 593269 

Review URL: https://codereview.chromium.org/1785483003

Cr-Commit-Position: refs/heads/master@{#380397}

[modify] https://crrev.com/f80d2873f5d74c33b908be46dd57ba01d5af6c36/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/f80d2873f5d74c33b908be46dd57ba01d5af6c36/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify] https://crrev.com/f80d2873f5d74c33b908be46dd57ba01d5af6c36/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02cfffa779037fd8db51b7cb8146753df51ed217

commit 02cfffa779037fd8db51b7cb8146753df51ed217
Author: haraken <haraken@chromium.org>
Date: Thu Mar 10 19:55:46 2016

Register ArrayBufferContents' adjustAmountOfMemory in V8Initializer::initialize

Currently ArrayBufferContents' adjustAmountOfMemory is registered in initializeWithoutV8
but this is not nice because adjustAmountOfMemory is a method used *with* V8.
The registration should be moved to V8Initializer::initialize.

BUG= 593269 

Review URL: https://codereview.chromium.org/1776943002

Cr-Commit-Position: refs/heads/master@{#380450}

[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/wtf/ArrayBufferContents.h
[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/wtf/WTF.h
[modify] https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217/third_party/WebKit/Source/wtf/testing/RunAllTests.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69718c022399c18cae3dbc2e12362adfac5d8b3f

commit 69718c022399c18cae3dbc2e12362adfac5d8b3f
Author: haraken <haraken@chromium.org>
Date: Fri Mar 11 05:30:06 2016

Move code to register/unregister memory dump provider from blink::initialize/shutdown

WebCacheMemoryDumpProvider is a core feature, so the initialization/shutdown
should be handled by CoreInitializer.

FontCacheMemoryDumpProvider is a platform features, so the initialization/shutdown
should be handled by Platform::initialize.

BUG= 593269 

Review URL: https://codereview.chromium.org/1773273004

Cr-Commit-Position: refs/heads/master@{#380530}

[modify] https://crrev.com/69718c022399c18cae3dbc2e12362adfac5d8b3f/third_party/WebKit/Source/core/Init.cpp
[modify] https://crrev.com/69718c022399c18cae3dbc2e12362adfac5d8b3f/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/69718c022399c18cae3dbc2e12362adfac5d8b3f/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daa2210782173ed9961d8eba2a5589f855e0c0fc

commit daa2210782173ed9961d8eba2a5589f855e0c0fc
Author: haraken <haraken@chromium.org>
Date: Fri Mar 11 10:28:46 2016

Move the contents of initializeWithoutV8/shutdownWithoutV8 to Platform::initialize/shutdown

Now that initializeWithoutV8/shutdownWithoutV8 doesn't have any dependency on
core, modules and wtf, we can move the contents to Platform::initialize/shutdown.

BUG= 593269 

Review URL: https://codereview.chromium.org/1785163002

Cr-Commit-Position: refs/heads/master@{#380592}

[modify] https://crrev.com/daa2210782173ed9961d8eba2a5589f855e0c0fc/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/daa2210782173ed9961d8eba2a5589f855e0c0fc/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify] https://crrev.com/daa2210782173ed9961d8eba2a5589f855e0c0fc/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45bafe4e8cdbc6185f133892b4fe57fe372b3fe2

commit 45bafe4e8cdbc6185f133892b4fe57fe372b3fe2
Author: haraken <haraken@chromium.org>
Date: Fri Mar 11 13:38:35 2016

Move LSan-specific shutdown code to ThreadState::cleanupMainThread

BUG= 593269 

Review URL: https://codereview.chromium.org/1787623003

Cr-Commit-Position: refs/heads/master@{#380621}

[modify] https://crrev.com/45bafe4e8cdbc6185f133892b4fe57fe372b3fe2/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/45bafe4e8cdbc6185f133892b4fe57fe372b3fe2/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2b5028e884282ae95b783ea8bc8f78ffebaabf0

commit c2b5028e884282ae95b783ea8bc8f78ffebaabf0
Author: haraken <haraken@chromium.org>
Date: Fri Mar 11 18:40:22 2016

Remove initializeWithoutV8 and shutdownWithoutV8

Now initializeWithoutV8/shutdownWithoutV8 is idential to Platform::initialize/shutdown.
This CL removes initializeWithoutV8/shutdownWithoutV8.

BUG= 593269 

Review URL: https://codereview.chromium.org/1787643003

Cr-Commit-Position: refs/heads/master@{#380682}

[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/components/test_runner/test_common.cc
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/content/browser/renderer_host/sandbox_ipc_linux.cc
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/third_party/WebKit/Source/web/ImageDecodeBench.cpp
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/c2b5028e884282ae95b783ea8bc8f78ffebaabf0/third_party/WebKit/public/web/WebKit.h
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a93d12a5e0b250e9c0e9b3b5d47208454c5e350

commit 3a93d12a5e0b250e9c0e9b3b5d47208454c5e350
Author: haraken <haraken@chromium.org>
Date: Sat Mar 12 04:43:37 2016

Remove WebPrerenderingSupport::shutdown from blink::shutdown

WebPrerenderingSupport::initialize/shutdown is called in
PrerenderDispatcher's constructor/destructor. There would be no need to
call WebPrerenderingSupport::shutdown from blink::shutdown.
(It looks strange to call WebPrerenderingSupport::shutdown in blink::shutdown
whereas WebPrerenderingSupport::initialize is not called in blink::initialize.)

The code was added in https://chromium.googlesource.com/chromium/src/+/b5d48114fbb738a58cb58b9023c1e25ea94a9ec0 four years ago.

BUG= 593269 

Review URL: https://codereview.chromium.org/1771393006

Cr-Commit-Position: refs/heads/master@{#380845}

[modify] https://crrev.com/3a93d12a5e0b250e9c0e9b3b5d47208454c5e350/third_party/WebKit/Source/platform/exported/Platform.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e67be9ca3492420dff5c960cd10789d5f0597ae3

commit e67be9ca3492420dff5c960cd10789d5f0597ae3
Author: haraken <haraken@chromium.org>
Date: Sat Mar 19 10:10:17 2016

Rename Init.h to CoreInitializer.h, and InitModules.h to ModuleInitializer.h

A file name should match with the class names in the file.

BUG= 593269 

Review URL: https://codereview.chromium.org/1776993007

Cr-Commit-Position: refs/heads/master@{#382193}

[modify] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/bindings/templates/partial_interface.cpp
[modify] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[rename] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/core/CoreInitializer.cpp
[rename] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/core/core.gypi
[rename] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[rename] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/modules/modules.gypi
[modify] https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3/third_party/WebKit/Source/web/WebKit.cpp
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9885fbb73f31efe0fbac0e6a077001024d88f0

commit eb9885fbb73f31efe0fbac0e6a077001024d88f0
Author: haraken <haraken@chromium.org>
Date: Tue Mar 22 08:59:19 2016

Merge WTF::initializeMainThread into WTF::initialize

This CL merges WTF::initializeMainThread into WTF::initialize.
Also it merges MainThread.h into WTF.h.

BUG= 593269 

Review URL: https://codereview.chromium.org/1818233003

Cr-Commit-Position: refs/heads/master@{#382533}

[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/DOMURL.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/QualifiedName.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/StyleChangeReason.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/TreeShared.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/dom/custom/CustomElementProcessingStack.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/fetch/WebCacheMemoryDumpProvider.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/inspector/InstanceCounters.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/timing/MemoryInfo.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/compositorworker/CompositorWorker.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/mediasource/MediaSourceRegistry.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/mediastream/MediaStreamRegistry.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/EventDispatchForbiddenScope.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/MemoryPurgeController.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/PlatformInstrumentation.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/PluginScriptForbiddenScope.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/ScriptForbiddenScope.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/UserGestureIndicator.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/blob/BlobRegistry.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/fonts/FontCacheMemoryDumpProvider.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/fonts/FontFallbackList.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/graphics/ColorSpaceProfileData.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/heap/Handle.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/heap/HeapPage.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/heap/PersistentNode.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/heap/RunAllTests.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/testing/RunAllTests.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/text/PlatformLocale.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/weborigin/DatabaseIdentifier.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/web/WebKit.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/ArrayBufferContents.h
[delete] https://crrev.com/01a402cd6fb6873e61d2faa269b6b991d307635e/third_party/WebKit/Source/wtf/MainThread.cpp
[delete] https://crrev.com/01a402cd6fb6873e61d2faa269b6b991d307635e/third_party/WebKit/Source/wtf/MainThread.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/Partitions.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/ThreadingWin.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/WTF.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/WTF.h
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/testing/RunAllTests.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/text/StringImpl.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/text/StringImplCF.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/text/StringStatics.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp
[modify] https://crrev.com/eb9885fbb73f31efe0fbac0e6a077001024d88f0/third_party/WebKit/Source/wtf/wtf.gypi

Comment 17 by haraken@chromium.org, Mar 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment