Password Manager doesn't save / autofill passwords on Citi credit cards |
|||||||
Issue descriptionChrome Version : 49.0.2623.75 OS Version: OS X 10.11.3 URLs (if applicable) : https://online.citi.com/US/Welcome.c, https://online.citi.com/US/JPS/portal/Index.do, https://www.citi.com/credit-cards/citi.action What steps will reproduce the problem? 1. Activate credit card on https://citi.com/activate 2. Create password, save it in password manager. Succeed at saving password, but not username. 3. Sign out 4. Try to sign in at one of the above URLs 5. No prompt to autofill username/password 6. Manually type in username/password 7. No prompt to save username/password What is the expected result? Autofills password Prompts to save manually entered username/password What happens instead of that? No autosave/prompt. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.75 Safari/537.36
,
Dec 14 2016
Issue 596477 has been merged into this issue.
,
Dec 15 2016
The login form contains 5 password elements (<input type="password">). 4 of them are hidden actually, but form_util::IsWebNodeVisible says visible for all. So, we have 5 password elements and give up to classify them (see LocateSpecificPasswords). form_util::IsWebNodeVisible must be fixed.
,
Dec 22 2016
Switching from IsWebNodeVisible (that check whether the element takes spaces) to IsFocusable fix this bug. I will fix it later.
,
Mar 23 2017
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7717d24507eb8aa830a8fdf7d5c202a43a8803ae commit 7717d24507eb8aa830a8fdf7d5c202a43a8803ae Author: kolos <kolos@chromium.org> Date: Tue Mar 28 12:16:42 2017 [Password Manager] Check node visibility with isFocusable instead of hasNonEmptyLayoutSize Autofill already uses isFocusable BUG= 593246 , 589533 Review-Url: https://codereview.chromium.org/2769023003 Cr-Commit-Position: refs/heads/master@{#460064} [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/components/autofill/content/renderer/form_autofill_util.cc [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/components/autofill/content/renderer/form_autofill_util.h [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/components/autofill/content/renderer/form_classifier.cc [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/components/autofill/content/renderer/password_form_conversion_utils.cc [modify] https://crrev.com/7717d24507eb8aa830a8fdf7d5c202a43a8803ae/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
,
Mar 29 2017
,
Mar 30 2017
What build of Chrome will this be in?
,
Mar 31 2017
M59
,
Sep 27 2017
This still doesn't work for me in M61.
,
Sep 27 2017
Saving part should work when this CL (https://chromium-review.googlesource.com/c/chromium/src/+/610080) is landed. Didn't have time for that for a while. Filling part needs more complex changes.
,
Sep 27 2017
I've been able to save passwords with the #enable-password-force-saving flag. The filling still doesn't work (which seems to be expected).
,
Sep 28 2017
Even the saving fails for me on https://online.citi.com/US/Welcome.c. I see cases where the wrong username is saved ("t**t" instead of "test") and the wrong password is saved (a single character instead of what I typed).
,
Jan 26 2018
,
Jan 26 2018
It works: - saving (automatic and fallback) - filling (there is a minor issue: the username field looks empty till a user clicks on the page) - Chrome saves correct username, w/o stars (I noticed this before, but I failed to get incorrect username in a bubble) |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vabr@chromium.org
, Mar 9 2016Status: Available (was: Untriaged)