[Media Router WebUI] First button sometimes focused when dialog opened. |
||||||
Issue description
When opening the MR dialog, sometimes the first button ('start' in whichever LTR/RTL) in the header is selected.
For example:
1. Open dialog.
2. Cast a youtube video.
3. Close dialog.
4. Open dialog again. Observe focused button. See screenshot.
Only observed on Mac.
OSX 10.11.3
Version 51.0.2671.0 canary (64-bit)
,
Mar 14 2016
Reopening because this will be an issue when MR autoresizing lands. A fix is out. :)
,
Mar 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/280874bcce6eaa1b31d65fcdbe7f31bdfe191434 commit 280874bcce6eaa1b31d65fcdbe7f31bdfe191434 Author: apacible <apacible@chromium.org> Date: Tue Mar 15 00:27:16 2016 [Media Router] Disable focus if not triggered by user. In some cases such as page load, an unexpected focus event is triggered separately from any user input (e.g. tab or click). Disable this without disabling focus in general; focus is still needed for accessibility reasons. BUG= 593221 Review URL: https://codereview.chromium.org/1799303002 Cr-Commit-Position: refs/heads/master@{#381130} [modify] https://crrev.com/280874bcce6eaa1b31d65fcdbe7f31bdfe191434/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html [modify] https://crrev.com/280874bcce6eaa1b31d65fcdbe7f31bdfe191434/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js [modify] https://crrev.com/280874bcce6eaa1b31d65fcdbe7f31bdfe191434/chrome/browser/resources/media_router/externs.js
,
Mar 15 2016
,
Mar 21 2016
,
Mar 21 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 21 2016
Please try to merge your change to M50 branch 2661 asap as we're getting closer to M50 beta candidate cut for this week. Thank you.
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32ccd64cce0c370052e2ef1ba2d4421a73de2f56 commit 32ccd64cce0c370052e2ef1ba2d4421a73de2f56 Author: Jennifer Apacible <apacible@google.com> Date: Mon Mar 21 17:59:36 2016 [Media Router] Disable focus if not triggered by user. In some cases such as page load, an unexpected focus event is triggered separately from any user input (e.g. tab or click). Disable this without disabling focus in general; focus is still needed for accessibility reasons. BUG= 593221 Review URL: https://codereview.chromium.org/1799303002 Cr-Commit-Position: refs/heads/master@{#381130} (cherry picked from commit 280874bcce6eaa1b31d65fcdbe7f31bdfe191434) Review URL: https://codereview.chromium.org/1821733002 . Cr-Commit-Position: refs/branch-heads/2661@{#318} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/32ccd64cce0c370052e2ef1ba2d4421a73de2f56/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html [modify] https://crrev.com/32ccd64cce0c370052e2ef1ba2d4421a73de2f56/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js [modify] https://crrev.com/32ccd64cce0c370052e2ef1ba2d4421a73de2f56/chrome/browser/resources/media_router/externs.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by apaci...@chromium.org
, Mar 9 2016