New issue
Advanced search Search tips

Issue 593211 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 462133
issue 636676



Sign in to add a comment

MacViews: Tabbed dialogs should use Left Arrow / Right Arrow for navigation between tabs.

Project Member Reported by karandeepb@chromium.org, Mar 9 2016 
Version: 48.0.2564.116
OS: Mac

What steps will reproduce the problem?
(1) Enable chrome://flags/#mac-views-dialogs.
(2) Go to Google.com
(3) Click on the "Green lock" icon on the address bar to open Website Settings bubble.
(4) Press Tab to shift focus.
(5) Observe there is no way to shift focus between Permissions and Connections tabs via keyboard.

On Other platforms, focus between different tabs can be changed via Ctrl+Tab and Ctrl+Shift+Tab - https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/controls/tabbed_pane/tabbed_pane.cc&q=tabbed_pane.cc&sq=package:chromium&type=cs&l=370. On Cocoa, generally left/right arrow keys are used to shift focus between tabs.

Comment 1 by tapted@chromium.org, Mar 9 2016 

There's a general problem here, but the tabbed view for this bubble (the "Origin Info Bubble" or OIB) is going away. Should look like this now:
Screen Shot 2016-03-09 at 7.39.17 PM.png
54.9 KB View Download
Screen Shot 2016-03-09 at 7.41.06 PM.png
53.4 KB View Download

Comment 2 by lafo...@chromium.org, Apr 20 2016

Labels: -Hotlist-MacViews Proj-MacViews

Comment 3 by karandeepb@chromium.org, Aug 11 2016

Blocking: 636676

Comment 4 by tapted@chromium.org, Dec 12 2016

Blocking: 462133

Comment 5 by patricia...@chromium.org, Dec 16 2016

Summary: MacViews: Tabbed dialogs should use Left Arrow / Right Arrow for navigation between tabs. (was: MacViews: Can't navigate focus between tabs in bubbles/dialogs via keyboard.)
This seems to have been fixed for MacViews since this bug was reported (maybe from Harmony updates?) - Ctrl + Tab and Ctrl + Shift + Tab works now. To reproduce since the tabbed view is gone from the OIB, I've been using the collected cookies dialog instead - open the OIB > Click "X in use" under the "Cookies" heading. That said, it still looks like we need to change the shortcut used to be left arrow/right arrow instead of Ctrl+Tab / Ctrl+Shift+Tab to be consistent with the rest of Cocoa.

Comment 6 by patricia...@chromium.org, Dec 16 2016

Components: -Internals>Views Internals>Views>Desktop
Status: WontFix (was: Available)
As per discussion offline with karandeepb, the left/right arrow navigation needed to be while the tabs were focused, so this is actually fully working with the current Harmony  views::TabbedPane. Full repro steps:

(1) Make sure full keyboard access is turned on (System Preferences > Keyboard > Shortcuts > Switch the radio button to "All controls".
(2) Enable chrome://flags/#secondary-ui-md.
(3) Go to Google.com
(4) Click on the "Green lock" icon / "Secure" text on the address bar to open Website Settings bubble.
(5) Click the "3 in use" (or whatever number) link under "Cookies" to get the collected cookies dialog to open.
(6) Press Tab until focus is on the "Allowed" tab.
(7) Press the left arrow and right arrow to change the current tab.

As mentioned previously, the cross-platform shortcuts also work to switch tabs (Ctrl+Tab / Ctrl+Shift+Tab). Since this is actually the same shortcut as used to switch between Finder and Safari tabs, I think it's fine to leave that working.

Closing this bug since everything seems to now be working as intended.
►

Sign in to add a comment