New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593205 link

Starred by 1 user
Status: Archived
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Mar 2017
Cc:
bbudge@chromium.org
█ servolk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Ensure the ppapi PRESUBMIT detects if thunks change without the IDL changing

Project Member Reported by raymes@chromium.org, Mar 9 2016 
A few times thunks have changed without the IDL changing which means that when they are regenerated, they change and things break.

See https://codereview.chromium.org/1778683003/ for more details.

We need to fix all the broken thunks and ensure this doesn't creep back in.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d0c88b74fd4f06a5681abf38a8ce3670344f411

commit 3d0c88b74fd4f06a5681abf38a8ce3670344f411
Author: raymes <raymes@chromium.org>
Date: Sun Mar 20 23:51:33 2016

Fix the PPB_Flash_Font_file thunk so it can be generated

A change to the PPB_Flash_Font_file thunk made it not able to be generated. This fixes it by adding a shared class which the generator expects to be there.

BUG= 593205 

Review URL: https://codereview.chromium.org/1797843002

Cr-Commit-Position: refs/heads/master@{#382237}

[modify] https://crrev.com/3d0c88b74fd4f06a5681abf38a8ce3670344f411/ppapi/ppapi_shared.gypi
[modify] https://crrev.com/3d0c88b74fd4f06a5681abf38a8ce3670344f411/ppapi/shared_impl/BUILD.gn
[add] https://crrev.com/3d0c88b74fd4f06a5681abf38a8ce3670344f411/ppapi/shared_impl/ppb_flash_font_file_shared.h
[modify] https://crrev.com/3d0c88b74fd4f06a5681abf38a8ce3670344f411/ppapi/thunk/ppb_flash_font_file_thunk.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40bb88adc217b6ef86c9357b97d0d65938816fc0

commit 40bb88adc217b6ef86c9357b97d0d65938816fc0
Author: raymes <raymes@chromium.org>
Date: Tue Mar 22 23:45:32 2016

Run ppapi/generators/generator.py

This runs the ppapi generator to regenerate out of date thunks. The only
changes in thunks should be:
1) <stdint.h> is added
2) Formatting may have changed

The thunks were manually git cl format'ed in a previous CL but since these
are generated it should be fine just to leave them with the formatting they
are generated with.

BUG= 593205 

Review URL: https://codereview.chromium.org/1820873005

Cr-Commit-Position: refs/heads/master@{#382734}

[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/generators/idl_thunk.py
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_audio_buffer_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_audio_encoder_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_camera_capabilities_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_camera_device_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_compositor_layer_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_compositor_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_console_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_device_ref_dev_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_display_color_profile_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_file_chooser_dev_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_file_io_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_file_system_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_find_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_flash_drm_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_flash_font_file_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_fullscreen_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_gamepad_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_graphics_2d_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_graphics_3d_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_host_resolver_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_image_data_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_instance_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_instance_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_media_stream_video_track_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_messaging_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_mouse_cursor_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_network_list_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_network_monitor_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_output_protection_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_platform_verification_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_printing_dev_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_truetype_font_dev_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_udp_socket_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_uma_private_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_url_loader_trusted_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_url_request_info_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_url_response_info_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_video_frame_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_view_dev_thunk.cc
[modify] https://crrev.com/40bb88adc217b6ef86c9357b97d0d65938816fc0/ppapi/thunk/ppb_view_thunk.cc
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 23 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by raymes@chromium.org, Mar 24 2017

Status: Archived (was: Untriaged)
This is still an issue but I won't get time to address it properly.
►

Sign in to add a comment