Extension browser action popups shouldn't have an inset |
|||||
Issue descriptionChrome Version : 50.0.2652.0 Currently the WebContents in a browser action popup is inset 1 pixel on Mac, and 2 pixels everywhere else, adding a white border around the edges of the bubble. The extension should be able to draw to the edges of the bubble like a regular web page. Currently, the popups inset from the edge to avoid the rectangular webcontents rendering outside the rounded corners of the bubble. So we can't just remove the margin or the bubbles become square (see attachments). But that's the lazy fix - we should instead clip the WebContents to the window mask (rounded corners and all). This is a general problem for all bubbles. E.g. the bookmarks bubble has square corners on the bottom because the "signin" promo panel paints a gray background outside the rounded corners - Issue 581600 . There's a general fix that works for MacViews - https://codereview.chromium.org/1718043003 For other views platforms, a fix along the lines of https://codereview.chromium.org/1633403002/diff/1/ui/views/view.cc might work
,
Jul 13 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2017
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76f82679ebf31c2144fe1af32b91ec62d22706fe commit 76f82679ebf31c2144fe1af32b91ec62d22706fe Author: Evan Stade <estade@chromium.org> Date: Tue Jul 25 18:30:28 2017 [Views] Round the corners of the extension popup's WebContents so we can make the contents flush with the bubble border. Also, for cases where we can't round the corners, only add margins at the top and bottom (not on left and right edges). Bug: 593203 Change-Id: Ib64315e27fee9adc7d661edd1d086941c11a4d47 Reviewed-on: https://chromium-review.googlesource.com/578232 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#489381} [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/chrome/browser/ui/views/extensions/extension_popup.cc [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/chrome/browser/ui/views/extensions/extension_popup.h [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/compositor/layer.cc [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/bubble/tray_bubble_view.cc [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/bubble/tray_bubble_view.h [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host.cc [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host.h [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host_aura.cc [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host_aura.h [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host_mac.h [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host_mac.mm [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/controls/native/native_view_host_wrapper.h [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/painter.cc [modify] https://crrev.com/76f82679ebf31c2144fe1af32b91ec62d22706fe/ui/views/painter.h
,
Sep 25 2017
,
Nov 7
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ew...@chromium.org
, Jul 12 2016