New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 593194 link

Starred by 1 user
Status: Fixed
Owner:
█ lima...@gmail.com
Last visit 28 days ago
Closed: Mar 2016
Cc:
rdevlin....@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make browserAction.setBadgeBackgroundColor supports color keyword

Project Member Reported by lima...@gmail.com, Mar 9 2016 
currently we don't support below color keyword.
chrome.browserAction.setBadgeBackgroundColor({color:"green"})

and it returns unreadable error message.
Unchecked runtime.lastError while running browserAction.setBadgeBackgroundColor: Unknown error.
at setIconStatus (chrome-extension://blnceljpkdfniagjdagcnfeceanjcipe/rap.js:17:24)
at chrome-extension://blnceljpkdfniagjdagcnfeceanjcipe/rap.js:86:3reportIfUnchecked @ extensions::lastError:133handleResponse @ extensions::sendRequest:78

I think we should return proper error message at least.

Refer to http://stackoverflow.com/questions/35852715/changing-chrome-extension-icon/35881188

Comment 1 by rdevlin....@chromium.org, Mar 9 2016 

SGTM!  I'd be all for supporting css colors, but you're right that a better error would be great in the meantime if that looks too complicated.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc1c838798d0c76f1c135f1791d3989ab7a2b01

commit 2fc1c838798d0c76f1c135f1791d3989ab7a2b01
Author: limasdf <limasdf@gmail.com>
Date: Thu Mar 10 11:14:33 2016

chrome.browserAction.setBadgeBackgroundColor accepts color keyword

Accepts color keyword like 'black', 'blue' from setBadgeBackgroundColor.
Also, if unable to parse color string, returns proper error message

TEST=browser_tests --gtest_filter=BrowserActionApiTest.BadgeBackgroundColor
extensions_unittests --gtest_filter=ImageUtilTest.*

BUG= 593194 

Review URL: https://codereview.chromium.org/1781563003

Cr-Commit-Position: refs/heads/master@{#380386}

[modify] https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
[modify] https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[add] https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01/chrome/test/data/extensions/api_test/browser_action/color/update4.html
[add] https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01/chrome/test/data/extensions/api_test/browser_action/color/update4.js
[modify] https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01/extensions/common/image_util.cc
[modify] https://crrev.com/2fc1c838798d0c76f1c135f1791d3989ab7a2b01/extensions/common/image_util_unittest.cc

Comment 3 by lima...@gmail.com, Mar 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment