horizontal smooth scroll goes to wrong position in RTL documents |
|||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Visit https://output.jsbin.com/mimage/quiet on Windows, Linux, or ChromeOS. 2. Click the left arrow button on the horizontal scrollbar. What is the expected result? Scroll one step to the left. What happens instead of that? Scroll jumps all the way to the left. This is caused by ScrollAnimator not accounting for RTL scroll origin correctly. It does not reproduce with --disable-smooth-scrolling.
,
Mar 9 2016
This breaks scrolling on any RTL page with a horizontal scrollbar. Workarounds are to drag the scrollbar thumb, or to disable smooth scrolling in about:flags. Requesting merge to M49 and M50.
,
Mar 9 2016
,
Mar 9 2016
,
Mar 9 2016
Verified in canary (51.0.2672.0).
,
Mar 9 2016
,
Mar 10 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 10 2016
[Automated comment] Request affecting a post-stable build (M49), manual review required.
,
Mar 10 2016
Please try to merge your change to M50 branch 2661 ASAP if you think it is a safe merge as we're very close to M50 Beta candidate cut. Thank you.
,
Mar 10 2016
Merge approved for M49 (branch 2623)
,
Mar 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a99a391f699f0f5d15f3c249dc404a84d6f3bde1 commit a99a391f699f0f5d15f3c249dc404a84d6f3bde1 Author: Steve Kobes <skobes@chromium.org> Date: Thu Mar 10 19:31:47 2016 Fix botched merge in http://crrev.com/984e315. BUG= 593186 TBR=szager Review URL: https://codereview.chromium.org/1782963003 . Cr-Commit-Position: refs/branch-heads/2623@{#610} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907} [modify] https://crrev.com/a99a391f699f0f5d15f3c249dc404a84d6f3bde1/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
,
Mar 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/484078e368c1718cc3b1508931eb6b9f5e561fd5 commit 484078e368c1718cc3b1508931eb6b9f5e561fd5 Author: Steve Kobes <skobes@chromium.org> Date: Thu Mar 10 19:40:18 2016 Account for scroll origin in scroll animators. Blink and cc have different notions of scroll offset - Blink's is relative to the scroll origin which is non-zero in RTL documents. The CompositorScrollOffsetAnimationCurve must work entirely in cc scroll offsets since it is handed over to cc which doesn't know about the scroll origin. This patch teaches ScrollAnimator and ProgrammaticScrollAnimator to convert in both directions when creating and using the curve object. BUG= 593186 Review URL: https://codereview.chromium.org/1776503002 Cr-Commit-Position: refs/heads/master@{#379974} (cherry picked from commit 0bb16600006793953292ee1e7fd8bf0a66f575dc) Review URL: https://codereview.chromium.org/1780993003 . Cr-Commit-Position: refs/branch-heads/2661@{#183} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl-expected.txt [add] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html [modify] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp [modify] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp [modify] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp [modify] https://crrev.com/484078e368c1718cc3b1508931eb6b9f5e561fd5/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
,
Mar 10 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/bling/chromium.git/+/a99a391f699f0f5d15f3c249dc404a84d6f3bde1 commit a99a391f699f0f5d15f3c249dc404a84d6f3bde1 Author: Steve Kobes <skobes@chromium.org> Date: Thu Mar 10 19:31:47 2016
,
Mar 14 2016
,
Mar 16 2016
Tested the issue on windows 7, Linux Ubuntu 14.04 using chrome version 50.0.2661.37.Scroll bar is moving step by step when clicking on left arrow. Please find the attached screen cast for the same. Adding TE-Verified label.
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by skobes@chromium.org
, Mar 9 2016